Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Move common files to deploy folder #3860

Merged
merged 2 commits into from
Jun 7, 2023
Merged

cleanup: Move common files to deploy folder #3860

merged 2 commits into from
Jun 7, 2023

Conversation

karthik-us
Copy link
Collaborator

@karthik-us karthik-us commented May 26, 2023 •
edited

Few common files related to deployments were kept
in the examples folder initially. Moving them to
deploy folder and updating the relevant files.

@mergify mergify bot added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/docs Issues and PRs related to documentation labels May 26, 2023
nixpanic
nixpanic reviewed May 26, 2023
View reviewed changes
docs/deploy-rbd.md Outdated Show resolved Hide resolved
riya-singhal31
riya-singhal31 previously approved these changes May 26, 2023
View reviewed changes
@mergify mergify bot dismissed riya-singhal31’s stale review May 30, 2023 14:24

Pull request has been modified.

nixpanic
nixpanic requested changes May 30, 2023
View reviewed changes
Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit for updating/reducing the path in the doc now that you moved the files.

Feel free to squash the commits in a single one too. Thanks for the continued efforts!

docs/deploy-cephfs.md Outdated Show resolved Hide resolved
@karthik-us karthik-us changed the title doc: Correct the ceph config path cleanup: Move common files to deploy folder May 30, 2023
@mergify mergify bot added the cleanup label May 30, 2023
@Madhu-1 Madhu-1 requested a review from nixpanic May 31, 2023 07:54
Madhu-1
Madhu-1 previously approved these changes May 31, 2023
View reviewed changes
@karthik-us
Copy link
Collaborator Author

@nixpanic & @riya-singhal31 please review.

yati1998
yati1998 previously approved these changes Jun 1, 2023
View reviewed changes
riya-singhal31
riya-singhal31 previously approved these changes Jun 1, 2023
View reviewed changes
@riya-singhal31 riya-singhal31 added the ok-to-test Label to trigger E2E tests label Jun 1, 2023
@nixpanic nixpanic removed the ci/skip/e2e skip running e2e CI jobs label Jun 1, 2023
@nixpanic
Copy link
Member

nixpanic commented Jun 1, 2023

I think the full e2e jobs need to run, not sure why Mergify added the ci/skip/e2e label (and no idea if it will add it again after I removed it).

@nixpanic
Copy link
Member

nixpanic commented Jun 1, 2023

This PR can be rebased (by Mergify) and CI jobs started once #3863 is merged.

@nixpanic
Copy link
Member

nixpanic commented Jun 1, 2023

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2023

rebase

✅ Branch has been successfully rebased

@nixpanic
Copy link
Member

nixpanic commented Jun 1, 2023

/test all

@nixpanic nixpanic removed the ok-to-test Label to trigger E2E tests label Jun 1, 2023
@nixpanic
Copy link
Member

nixpanic commented Jun 1, 2023

/test ci/centos/k8s-e2e-external-storage

@nixpanic
Copy link
Member

nixpanic commented Jun 1, 2023

/test ci/centos/mini-e2e-helm

@nixpanic
Copy link
Member

nixpanic commented Jun 1, 2023

/test ci/centos/mini-e2e

@nixpanic
Copy link
Member

nixpanic commented Jun 7, 2023

@Mergifyio rebase

@karthik-us @nixpanic
cleanup: Move common files to deploy folder
86ef65d 
Few common files related to deployments were kept
in the examples folder initially. Moving them to
deploy folder and updating the relevant files.

Signed-off-by: karthik-us <ksubrahm@redhat.com>
@karthik-us @nixpanic
e2e: Make getConfigFile() generic
3b1cb50 
Update the getConfigFile() function to allow any file to be looked
at on the preferred location first and fall back to the alternate
location if it does not exist there.

Signed-off-by: karthik-us <ksubrahm@redhat.com>
@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2023

rebase

✅ Branch has been successfully rebased

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Jun 7, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.24

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.25

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.24

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.25

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.24

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.25

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jun 7, 2023
@nixpanic
Copy link
Member

nixpanic commented Jun 7, 2023

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2023 •
edited

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at e4e373c

@karthik-us
Copy link
Collaborator Author

karthik-us commented Jun 7, 2023 •
edited

/assign @karthik-us

@nixpanic
Copy link
Member

nixpanic commented Jun 7, 2023

/retest ci/centos/mini-e2e/k8s-1.25

@nixpanic
Copy link
Member

nixpanic commented Jun 7, 2023

/retest ci/centos/mini-e2e/k8s-1.25

Deploying rook seems to have failed? https://jenkins-ceph-csi.apps.ocp.cloud.ci.centos.org/blue/organizations/jenkins/mini-e2e_k8s-1.25/detail/mini-e2e_k8s-1.25/505/pipeline

@karthik-us
Copy link
Collaborator Author

Deploying rook seems to have failed? https://jenkins-ceph-csi.apps.ocp.cloud.ci.centos.org/blue/organizations/jenkins/mini-e2e_k8s-1.25/detail/mini-e2e_k8s-1.25/505/pipeline

Is there any problem with the Jenkins instance? Now the rook deployment succeeded, but e2e run seems to be stuck.
https://jenkins-ceph-csi.apps.ocp.cloud.ci.centos.org/blue/organizations/jenkins/mini-e2e_k8s-1.25/detail/mini-e2e_k8s-1.25/506/pipeline/
How much time does it usually take?

@mergify mergify bot merged commit e4e373c into ceph:devel Jun 7, 2023
27 checks passed
@karthik-us
Copy link
Collaborator Author

Deploying rook seems to have failed? https://jenkins-ceph-csi.apps.ocp.cloud.ci.centos.org/blue/organizations/jenkins/mini-e2e_k8s-1.25/detail/mini-e2e_k8s-1.25/505/pipeline

Is there any problem with the Jenkins instance? Now the rook deployment succeeded, but e2e run seems to be stuck. https://jenkins-ceph-csi.apps.ocp.cloud.ci.centos.org/blue/organizations/jenkins/mini-e2e_k8s-1.25/detail/mini-e2e_k8s-1.25/506/pipeline/ How much time does it usually take?

Finally it passed. Thanks @nixpanic for the regular follow ups on this and thanks to all the reviewers.

@karthik-us karthik-us deleted the deploy-rbd-doc-update branch June 7, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixpanic nixpanic nixpanic approved these changes

@yati1998 yati1998 yati1998 approved these changes

@riya-singhal31 riya-singhal31 riya-singhal31 approved these changes

@Madhu-1 Madhu-1 Awaiting requested review from Madhu-1

Assignees
No one assigned
Labels
ci/skip/multi-arch-build skip building on multiple architectures cleanup component/docs Issues and PRs related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@karthik-us @nixpanic @yati1998 @ceph-csi-bot @Madhu-1 @riya-singhal31