Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use dependabot group feature #4087

Merged
merged 1 commit into from
Aug 29, 2023
Merged

ci: use dependabot group feature #4087

merged 1 commit into from
Aug 29, 2023

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Aug 29, 2023

enable dependabot raising PR by groups to reduce PR and save CI resources.
This uses the beta groups feature of dependabot. More details here https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#groups

@Madhu-1 Madhu-1 added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures labels Aug 29, 2023
@Madhu-1 Madhu-1 requested review from a team August 29, 2023 07:24
@mergify mergify bot added the component/testing Additional test cases or CI work label Aug 29, 2023
yati1998
yati1998 previously approved these changes Aug 29, 2023
View reviewed changes
riya-singhal31
riya-singhal31 previously approved these changes Aug 29, 2023
View reviewed changes
@Madhu-1 Madhu-1 requested a review from nixpanic August 29, 2023 08:38
@mergify mergify bot dismissed stale reviews from riya-singhal31 and yati1998 August 29, 2023 08:38

Pull request has been modified.

subhamkrai
subhamkrai reviewed Aug 29, 2023
View reviewed changes
.github/dependabot.yml
groups:
golang-dependencies:
patterns:
- "github.com/golang*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "github.com/golang*"
- "github.com/golang**"

question, will this be ** or * in patterns?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be * as i have seen here

subhamkrai
subhamkrai reviewed Aug 29, 2023
View reviewed changes
.github/dependabot.yml
Comment on lines +16 to +20
- "k8s.io*"
- "sigs.k8s.io*"
github-dependencies:
patterns:
- "github.com*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- "k8s.io*"
- "sigs.k8s.io*"
github-dependencies:
patterns:
- "github.com*"
- "k8s.io*"
- "sigs.k8s.io*"
github-dependencies:
patterns:
- "github.com*"

I think for k8s.io*" and sigs.k8s.io*", singe * make sense since it has only once string to match for example

k8s.io/cloud-provider

only cloud-provider

but for github.com I think it will github.com/** since it has to make a recursive search

github.com/spf13/cobra

/spf13 and /cobra

I guess I'm not confusing things but I have seen /** for recursive search for example branch search

tags:
      - v*
    branches:
      - master
      - release-*
  pull_request:
    branches:
      - master
      - release-*
    paths-ignore:
      - "Documentation/**"

from here https://github.com/rook/rook/blob/master/.github/workflows/canary-integration-test.yml#L4-L15
- "design/**"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @subhamkrai For me this looks to be enough, will revisit this if required in the followup PR.

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 29, 2023

@merigyfyio queue

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 29, 2023

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2023 •
edited

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge train check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@Madhu-1
ci: use dependabot group feature
a897e01 
enable dependabot raising PR by groups to
reduce PR and save CI resources.
This uses the  beta groups feature of dependabot
More details here
https://docs.github.com/en/code-security/\
dependabot/dependabot-version-updates/\
configuration-options-for-the-dependabot.yml-file#groups

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Aug 29, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Aug 29, 2023
@Madhu-1 Madhu-1 added ci/retry/e2e Label to retry e2e retesting on approved PR's and removed ci/retry/e2e Label to retry e2e retesting on approved PR's labels Aug 29, 2023
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 29, 2023

/test ci/centos/upgrade-tests-rbd

@Madhu-1 Madhu-1 added the ci/retry/e2e Label to retry e2e retesting on approved PR's label Aug 29, 2023
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 29, 2023

/test ci/centos/mini-e2e-helm

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 29, 2023

/test ci/centos/mini-e2e

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 29, 2023

/test ci/centos/upgrade-tests-cephfs

@Madhu-1 Madhu-1 removed the ci/retry/e2e Label to retry e2e retesting on approved PR's label Aug 29, 2023
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 29, 2023

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2023

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge train check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 29, 2023

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2023

refresh

✅ Pull request refreshed

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 29, 2023

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2023

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 4a8c901 into ceph:devel Aug 29, 2023
43 checks passed
@Madhu-1 Madhu-1 mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixpanic nixpanic nixpanic approved these changes

@karthik-us karthik-us karthik-us approved these changes

@subhamkrai subhamkrai subhamkrai approved these changes

@riya-singhal31 riya-singhal31 riya-singhal31 approved these changes

@yati1998 yati1998 yati1998 left review comments

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/testing Additional test cases or CI work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Madhu-1 @ceph-csi-bot @nixpanic @karthik-us @yati1998 @subhamkrai @riya-singhal31