Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cephfs: Add support to create RWX PVC from ROX PVC #4094

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Aug 30, 2023

This PR blocks the creation of ROX clone from ROX volume as there is no use case currently. Add support to create an RWX clone from the ROX clone, in ceph No subvolume clone is created when the ROX clone is created from a snapshot just an internal ref counter is added. This PR allows creating an RWX clone from an ROX clone which allows users to create an RW copy of PVC where cephcsi will identify the snapshot created for the ROX volume and create a subvolume from the CephFS snapshot.

@mergify mergify bot added the component/cephfs Issues related to CephFS label Aug 30, 2023
@Madhu-1 Madhu-1 requested review from riya-singhal31 and a team August 30, 2023 10:26
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 30, 2023

/test ci/centos/mini-e2e/k8s-1.28

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 30, 2023

/test ci/centos/mini-e2e/k8s-1.28

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 30, 2023

/test ci/centos/mini-e2e/k8s-1.28

nixpanic
nixpanic previously approved these changes Aug 30, 2023
@Madhu-1 Madhu-1 requested a review from a team August 30, 2023 13:50
riya-singhal31
riya-singhal31 previously approved these changes Aug 30, 2023
Copy link
Contributor

@riya-singhal31 riya-singhal31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Madhu

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 30, 2023

/test ci/centos/mini-e2e/k8s-1.28

@mergify mergify bot dismissed stale reviews from riya-singhal31 and nixpanic August 30, 2023 15:00

Pull request has been modified.

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 31, 2023

/test ci/centos/mini-e2e/k8s-1.28

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 31, 2023

Finally CI passes 👍🏻

@nixpanic nixpanic requested a review from a team August 31, 2023 09:18
@riya-singhal31
Copy link
Contributor

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2023

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 9809f36

As there is no usecase currently, blocking the
creation of ROX clone from the ROX volume.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Add support to create RWX clone from the
ROX clone, in ceph no subvolume clone is
created when ROX clone is created from a
snapshot just a internal ref counter is
added. This PR allows creating a RWX clone
from a ROX clone which allows users to create
RW copy of PVC where cephcsi will identify
the snapshot created for the ROX volume and
creates a subvolume from the CephFS snapshot.

updates: ceph#3603

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
added an e2e test case to create
RWX clone from ROX and also try
to write extra data in the RWX
cloned PVC.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@riya-singhal31 riya-singhal31 added the ok-to-test Label to trigger E2E tests label Aug 31, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Aug 31, 2023
@mergify mergify bot merged commit 9809f36 into ceph:devel Aug 31, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/cephfs Issues related to CephFS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants