Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc:add reference to CSI snapshot deployment guide #4119

Merged
merged 1 commit into from
Sep 14, 2023
Merged

doc:add reference to CSI snapshot deployment guide #4119

merged 1 commit into from
Sep 14, 2023

Conversation

iPraveenParihar
Copy link
Contributor

@iPraveenParihar iPraveenParihar commented Sep 12, 2023 •
edited

Describe what this PR does

This change adds reference to CSI snapshot CRDs
deployment guide in deploy-cephfs.md and deploy-rbd.md

Closes: #4100

@mergify mergify bot added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/docs Issues and PRs related to documentation labels Sep 12, 2023
@iPraveenParihar iPraveenParihar marked this pull request as ready for review September 12, 2023 05:46
Rakshith-R
Rakshith-R requested changes Sep 12, 2023
View reviewed changes
docs/deploy-cephfs.md Outdated
Comment on lines 154 to 156
**Deploy CSI Snapshot:**

If you intend to use the snapshot functionality in your Kuberenetes cluster, please refer [deployment guide](./snap-clone.md#prerequisite)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Deploy CSI Snapshot:**
If you intend to use the snapshot functionality in your Kuberenetes cluster, please refer [deployment guide](./snap-clone.md#prerequisite)
**Deploy prerequisites for CSI Snapshot:**
If you intend to use the snapshot functionality in your Kuberenetes cluster, please refer to [snap-clone.md](./snap-clone.md#prerequisite)

Madhu-1
Madhu-1 requested changes Sep 12, 2023
View reviewed changes
docs/deploy-cephfs.md Outdated
@@ -151,6 +151,11 @@ for more information.
kubectl create -f ../../ceph-conf.yaml
```

**Deploy prerequisites for CSI Snapshot:**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Deploy prerequisites for CSI Snapshot:**
**Deploy prerequisites for CSI Snapshot:**

docs/deploy-cephfs.md Outdated
@@ -151,6 +151,11 @@ for more information.
kubectl create -f ../../ceph-conf.yaml
```

**Deploy prerequisites for CSI Snapshot:**

If you intend to use the snapshot functionality in your Kuberenetes cluster,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you intend to use the snapshot functionality in your Kuberenetes cluster,
If you intend to use the snapshot functionality in Kubernetes cluster,

Madhu-1
Madhu-1 previously approved these changes Sep 12, 2023
View reviewed changes
Madhu-1
Madhu-1 reviewed Sep 12, 2023
View reviewed changes
docs/deploy-cephfs.md Outdated
@@ -151,6 +151,11 @@ for more information.
kubectl create -f ../../ceph-conf.yaml
```

**Deploy prerequisites for CSI Snapshot:**

If you intend to use the snapshot functionality in Kuberenetes cluster,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still you have typo in Kubernetes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, missed it!

@mergify mergify bot dismissed Madhu-1’s stale review September 12, 2023 07:18

Pull request has been modified.

Rakshith-R
Rakshith-R previously approved these changes Sep 12, 2023
View reviewed changes
riya-singhal31
riya-singhal31 previously approved these changes Sep 12, 2023
View reviewed changes
Madhu-1
Madhu-1 previously approved these changes Sep 12, 2023
View reviewed changes
@Rakshith-R
Copy link
Contributor

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2023 •
edited

queue

🛑 The pull request has been removed from the queue default

Unexpected queue change: the updated pull request #4119 has been manually updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Sep 13, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@Rakshith-R
Copy link
Contributor

@iPraveenParihar please rebase this pr manually after this pr #4124 merges.

@iPraveenParihar
doc: add info about csi snapshot deployment
304cad9 
This commit includes reference to CSI snapshot CRDs
deployment guide.

Signed-off-by: Praveen M <m.praveen@ibm.com>
@mergify mergify bot dismissed stale reviews from Rakshith-R and Madhu-1 September 14, 2023 14:23

Pull request has been modified.

@Rakshith-R Rakshith-R removed the DNM DO NOT MERGE label Sep 14, 2023
@Rakshith-R Rakshith-R added the ok-to-test Label to trigger E2E tests label Sep 14, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Sep 14, 2023
@Rakshith-R Rakshith-R requested a review from a team September 14, 2023 14:46
@Rakshith-R
Copy link
Contributor

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2023

requeue

❌ This pull request head commit has not been previously disembarked from queue.

@Rakshith-R
Copy link
Contributor

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2023

queue

🟠 Waiting for conditions to match

  • any of: [:twisted_rightwards_arrows: queue conditions]
    • all of: [:pushpin: queue conditions of queue default]
      • #approved-reviews-by>=2 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • -draft [:pushpin: queue requirement]
  • -mergify-configuration-changed [:pushpin: queue -> allow_merging_configuration_change setting requirement]

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Sep 14, 2023

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2023 •
edited

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 137914b

@mergify mergify bot merged commit 137914b into ceph:devel Sep 14, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@riya-singhal31 riya-singhal31 Awaiting requested review from riya-singhal31

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/docs Issues and PRs related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing CRDs of the CSI Snapshotter in the "deploy" Ressources
5 participants
@iPraveenParihar @Rakshith-R @ceph-csi-bot @Madhu-1 @riya-singhal31