ci: disable addons after cluster creation #4170

Madhu-1 · 2023-10-09T11:18:25Z

Disabling add-on pre-cluster creation is not working, Moving the disable addons to post-cluster creation.
I added 2nd commit to remove support for the older version of Rook as well.

Current script output

[🎩︎]mrajanna@li-2cfbef4c-22d9-11b2-a85c-a3e4a93c405f ceph-csi $]./scripts/minikube.sh up
😄  minikube v1.31.0 on Fedora 38
    ▪ KUBECONFIG=/home/mrajanna/workspace/src/github.com/JohnStrunk/k8s-cluster/kubeconfig
    ▪ MINIKUBE_VERSION=v1.31.2
❗  minikube skips various validations when --force is supplied; this may lead to unexpected behavior
🎉  minikube 1.31.2 is available! Download it: https://github.com/kubernetes/minikube/releases/tag/v1.31.2
💡  To disable this notice, run: 'minikube config set WantUpdateNotification false'

✨  Using the kvm2 driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🔥  Creating kvm2 VM (CPUs=12, Memory=4096MB, Disk=32768MB) ...
🐳  Preparing Kubernetes v1.27.2 on Docker 24.0.4 ...
    ▪ kubelet.resolv-conf=/run/systemd/resolve/resolv.conf
    ▪ kubelet.read-only-port=10255
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔗  Configuring bridge CNI (Container Networking Interface) ...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🔎  Verifying Kubernetes components...
🌟  Enabled addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default
root        2113    2057 44 11:06 ?        00:00:12 kube-apiserver --advertise-address=192.168.39.66 --allow-privileged=true --authorization-mode=Node,RBAC --client-ca-file=/var/lib/minikube/certs/ca.crt --enable-admission-plugins=NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota --enable-bootstrap-token-auth=true --etcd-cafile=/var/lib/minikube/certs/etcd/ca.crt --etcd-certfile=/var/lib/minikube/certs/apiserver-etcd-client.crt --etcd-keyfile=/var/lib/minikube/certs/apiserver-etcd-client.key --etcd-servers=https://127.0.0.1:2379 --feature-gates=ReadWriteOncePod=true,RecoverVolumeExpansionFailure=true --kubelet-client-certificate=/var/lib/minikube/certs/apiserver-kubelet-client.crt --kubelet-client-key=/var/lib/minikube/certs/apiserver-kubelet-client.key --kubelet-preferred-address-types=InternalIP,ExternalIP,Hostname --proxy-client-cert-file=/var/lib/minikube/certs/front-proxy-client.crt --proxy-client-key-file=/var/lib/minikube/certs/front-proxy-client.key --requestheader-allowed-names=front-proxy-client --requestheader-client-ca-file=/var/lib/minikube/certs/front-proxy-ca.crt --requestheader-extra-headers-prefix=X-Remote-Extra- --requestheader-group-headers=X-Remote-Group --requestheader-username-headers=X-Remote-User --secure-port=8443 --service-account-issuer=https://kubernetes.default.svc.cluster.local --service-account-key-file=/var/lib/minikube/certs/sa.pub --service-account-signing-key-file=/var/lib/minikube/certs/sa.key --service-cluster-ip-range=10.96.0.0/12 --tls-cert-file=/var/lib/minikube/certs/apiserver.crt --tls-private-key-file=/var/lib/minikube/certs/apiserver.key
root        4195       1 53 11:07 ?        00:00:00 /var/lib/minikube/binaries/v1.27.2/kubelet --bootstrap-kubeconfig=/etc/kubernetes/bootstrap-kubelet.conf --config=/var/lib/kubelet/config.yaml --container-runtime-endpoint=unix:///var/run/cri-dockerd.sock --feature-gates=ReadWriteOncePod=true,RecoverVolumeExpansionFailure=true --hostname-override=minikube --kubeconfig=/etc/kubernetes/kubelet.conf --node-ip=192.168.39.66 --read-only-port=10255 --resolv-conf=/run/systemd/resolve/resolv.conf --v=4
docker      4289    4270  0 11:07 pts/0    00:00:00 bash -c ps -Af |grep kubelet
docker      4291    4289  0 11:07 pts/0    00:00:00 grep kubelet
Kubernetes control plane is running at https://192.168.39.66:8443
CoreDNS is running at https://192.168.39.66:8443/api/v1/namespaces/kube-system/services/kube-dns:dns/proxy

To further debug and diagnose cluster problems, use 'kubectl cluster-info dump'.

[🎩︎]mrajanna@li-2cfbef4c-22d9-11b2-a85c-a3e4a93c405f ceph-csi $]minikube addons list
|-----------------------------|----------|--------------|--------------------------------|
|         ADDON NAME          | PROFILE  |    STATUS    |           MAINTAINER           |
|-----------------------------|----------|--------------|--------------------------------|
| ambassador                  | minikube | disabled     | 3rd party (Ambassador)         |
| auto-pause                  | minikube | disabled     | minikube                       |
| cloud-spanner               | minikube | disabled     | Google                         |
| csi-hostpath-driver         | minikube | disabled     | Kubernetes                     |
| dashboard                   | minikube | disabled     | Kubernetes                     |
| default-storageclass        | minikube | enabled ✅   | Kubernetes                     |
| efk                         | minikube | disabled     | 3rd party (Elastic)            |
| freshpod                    | minikube | disabled     | Google                         |
| gcp-auth                    | minikube | disabled     | Google                         |
| gvisor                      | minikube | disabled     | minikube                       |
| headlamp                    | minikube | disabled     | 3rd party (kinvolk.io)         |
| helm-tiller                 | minikube | disabled     | 3rd party (Helm)               |
| inaccel                     | minikube | disabled     | 3rd party (InAccel             |
|                             |          |              | [info@inaccel.com])            |
| ingress                     | minikube | disabled     | Kubernetes                     |
| ingress-dns                 | minikube | disabled     | minikube                       |
| inspektor-gadget            | minikube | disabled     | 3rd party                      |
|                             |          |              | (inspektor-gadget.io)          |
| istio                       | minikube | disabled     | 3rd party (Istio)              |
| istio-provisioner           | minikube | disabled     | 3rd party (Istio)              |
| kong                        | minikube | disabled     | 3rd party (Kong HQ)            |
| kubevirt                    | minikube | disabled     | 3rd party (KubeVirt)           |
| logviewer                   | minikube | disabled     | 3rd party (unknown)            |
| metallb                     | minikube | disabled     | 3rd party (MetalLB)            |
| metrics-server              | minikube | disabled     | Kubernetes                     |
| nvidia-driver-installer     | minikube | disabled     | 3rd party (Nvidia)             |
| nvidia-gpu-device-plugin    | minikube | disabled     | 3rd party (Nvidia)             |
| olm                         | minikube | disabled     | 3rd party (Operator Framework) |
| pod-security-policy         | minikube | disabled     | 3rd party (unknown)            |
| portainer                   | minikube | disabled     | 3rd party (Portainer.io)       |
| registry                    | minikube | disabled     | minikube                       |
| registry-aliases            | minikube | disabled     | 3rd party (unknown)            |
| registry-creds              | minikube | disabled     | 3rd party (UPMC Enterprises)   |
| storage-provisioner         | minikube | enabled ✅   | minikube                       |
| storage-provisioner-gluster | minikube | disabled     | 3rd party (Gluster)            |
| volumesnapshots             | minikube | disabled     | Kubernetes                     |
|-----------------------------|----------|--------------|--------------------------------|

riya-singhal31

LGTM

Pull request has been modified.

nixpanic · 2023-10-10T10:54:12Z

This can be rebased + ok-to-test labelled once #4178 is merged.

Madhu-1 · 2023-10-10T11:56:14Z

@Mergifyio rebase

It looks like disabling addson pre cluster creation is not working, Moving the disable addons to post cluster creation. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

As we are having latest version of Rook, Removing the support for pretty older version of Rook. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

Update the Rook to point to the latest release as script support it. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

mergify · 2023-10-10T11:56:43Z

rebase

✅ Branch has been successfully rebased

Madhu-1 · 2023-10-10T11:57:22Z

@Mergifyio queue

mergify · 2023-10-10T11:57:26Z

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 31d84b1

ceph-csi-bot · 2023-10-10T11:57:45Z

/test ci/centos/upgrade-tests-cephfs

ceph-csi-bot · 2023-10-10T11:57:46Z

/test ci/centos/upgrade-tests-rbd

ceph-csi-bot · 2023-10-10T11:57:57Z

/test ci/centos/k8s-e2e-external-storage/1.27

ceph-csi-bot · 2023-10-10T11:57:58Z

/test ci/centos/mini-e2e-helm/k8s-1.27

ceph-csi-bot · 2023-10-10T11:57:59Z

/test ci/centos/mini-e2e/k8s-1.27

ceph-csi-bot · 2023-10-10T11:58:09Z

/test ci/centos/k8s-e2e-external-storage/1.28

ceph-csi-bot · 2023-10-10T11:58:10Z

/test ci/centos/mini-e2e-helm/k8s-1.28

ceph-csi-bot · 2023-10-10T11:58:12Z

/test ci/centos/mini-e2e/k8s-1.28

ceph-csi-bot · 2023-10-10T11:58:21Z

/test ci/centos/k8s-e2e-external-storage/1.26

ceph-csi-bot · 2023-10-10T11:58:22Z

/test ci/centos/mini-e2e-helm/k8s-1.26

ceph-csi-bot · 2023-10-10T11:58:23Z

/test ci/centos/mini-e2e/k8s-1.26

Madhu-1 added the ci/skip/multi-arch-build skip building on multiple architectures label Oct 9, 2023

mergify bot added the component/testing Additional test cases or CI work label Oct 9, 2023

Madhu-1 requested review from a team October 10, 2023 05:58

riya-singhal31 previously approved these changes Oct 10, 2023

View reviewed changes

Rakshith-R previously approved these changes Oct 10, 2023

View reviewed changes

Madhu-1 force-pushed the fix-disable-addons branch from e4ec34c to 84bb94b Compare October 10, 2023 07:29

nixpanic previously approved these changes Oct 10, 2023

View reviewed changes

Madhu-1 force-pushed the fix-disable-addons branch from 84bb94b to 19f7378 Compare October 10, 2023 07:31

Madhu-1 force-pushed the fix-disable-addons branch from 19f7378 to 6c3f309 Compare October 10, 2023 07:33

Madhu-1 requested review from nixpanic, Rakshith-R and riya-singhal31 October 10, 2023 07:51

Rakshith-R approved these changes Oct 10, 2023

View reviewed changes

riya-singhal31 approved these changes Oct 10, 2023

View reviewed changes

Madhu-1 added 3 commits October 10, 2023 11:56

ci: disable addons after cluster creation

f456dd7

It looks like disabling addson pre cluster creation is not working, Moving the disable addons to post cluster creation. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

ci: remove support for older version of Rook

d291740

As we are having latest version of Rook, Removing the support for pretty older version of Rook. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

ci: update Rook to latest release

d19b0ac

Update the Rook to point to the latest release as script support it. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>

Madhu-1 force-pushed the fix-disable-addons branch from 6c3f309 to d19b0ac Compare October 10, 2023 11:56

mergify bot added the ok-to-test Label to trigger E2E tests label Oct 10, 2023

ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Oct 10, 2023

mergify bot merged commit 31d84b1 into ceph:devel Oct 10, 2023
34 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: disable addons after cluster creation #4170

ci: disable addons after cluster creation #4170

Madhu-1 commented Oct 9, 2023 •

edited

riya-singhal31 left a comment

nixpanic commented Oct 10, 2023

Madhu-1 commented Oct 10, 2023

mergify bot commented Oct 10, 2023

Madhu-1 commented Oct 10, 2023

mergify bot commented Oct 10, 2023 •

edited

ceph-csi-bot commented Oct 10, 2023

ceph-csi-bot commented Oct 10, 2023

ceph-csi-bot commented Oct 10, 2023

ceph-csi-bot commented Oct 10, 2023

ceph-csi-bot commented Oct 10, 2023

ceph-csi-bot commented Oct 10, 2023

ceph-csi-bot commented Oct 10, 2023

ceph-csi-bot commented Oct 10, 2023

ceph-csi-bot commented Oct 10, 2023

ceph-csi-bot commented Oct 10, 2023

ceph-csi-bot commented Oct 10, 2023

ci: disable addons after cluster creation #4170

ci: disable addons after cluster creation #4170

Conversation

Madhu-1 commented Oct 9, 2023 • edited

riya-singhal31 left a comment

Choose a reason for hiding this comment

nixpanic commented Oct 10, 2023

Madhu-1 commented Oct 10, 2023

mergify bot commented Oct 10, 2023

✅ Branch has been successfully rebased

Madhu-1 commented Oct 10, 2023

mergify bot commented Oct 10, 2023 • edited

✅ The pull request has been merged automatically

ceph-csi-bot commented Oct 10, 2023

ceph-csi-bot commented Oct 10, 2023

ceph-csi-bot commented Oct 10, 2023

ceph-csi-bot commented Oct 10, 2023

ceph-csi-bot commented Oct 10, 2023

ceph-csi-bot commented Oct 10, 2023

ceph-csi-bot commented Oct 10, 2023

ceph-csi-bot commented Oct 10, 2023

ceph-csi-bot commented Oct 10, 2023

ceph-csi-bot commented Oct 10, 2023

ceph-csi-bot commented Oct 10, 2023

Madhu-1 commented Oct 9, 2023 •

edited

mergify bot commented Oct 10, 2023 •

edited