helm: add annotations for ceph-csi-rbd secret #4248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
the
component/deployment
|
@mustdiechik can you please fix DCO error https://github.com/ceph/ceph-csi/pull/4248/checks?check_run_id=18476883886 ? |
Madhu-1
reviewed
Nov 8, 2023
mustdiechik
force-pushed
the
secret-annotations
branch
2 times, most recently
from
bd49b44
to
b3aa267
Compare
Madhu-1
approved these changes
Nov 9, 2023
yati1998
approved these changes
Nov 9, 2023
|
@Mergifyio rebase |
To use mutating webhook to modify secrets. For example banzaicloud vault webhook: https://bank-vaults.dev/docs/mutating-webhook/annotations/ Signed-off-by: Ruslan Khizhnyak <mustdiechik@gmail.com>
✅ Branch has been successfully rebased |
nixpanic
force-pushed
the
secret-annotations
branch
from
b3aa267
to
f653088
Compare
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 802f22f |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To use mutating webhook to modify secrets.
For example banzaicloud vault webhook:
https://bank-vaults.dev/docs/mutating-webhook/annotations/