Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cephfs: fix network fencing admin id #4316

Merged
merged 1 commit into from
Dec 12, 2023
Merged

cephfs: fix network fencing admin id #4316

merged 1 commit into from
Dec 12, 2023

Conversation

riya-singhal31
Copy link
Contributor

@riya-singhal31 riya-singhal31 commented Dec 12, 2023 •
edited

closes: #4315

@mergify mergify bot added component/cephfs Issues related to CephFS bug Something isn't working labels Dec 12, 2023
@riya-singhal31
Copy link
Contributor Author

riyasinghal@rsinghal-mac examples % kubectl get networkfences.csiaddons.openshift.io -o yaml
apiVersion: v1
items:

  • apiVersion: csiaddons.openshift.io/v1alpha1
    kind: NetworkFence
    metadata:
    creationTimestamp: "2023-12-12T14:14:54Z"
    generation: 1
    name: network-fence-sample
    resourceVersion: "46073"
    uid: da427fd3-edf7-44bf-a0e5-dee0795c9399
    spec:
    cidrs:
    • 10.90.89.66/32
    • 11.67.12.42/24
      driver: rook-ceph.cephfs.csi.ceph.com
      fenceState: Fenced
      parameters:
      clusterID: rook-ceph
      secret:
      name: rook-csi-cephfs-provisioner
      namespace: rook-ceph
      kind: List
      metadata:
      resourceVersion: ""
      riyasinghal@rsinghal-mac examples % kubectl get networkfences.csiaddons.openshift.io
      NAME DRIVER CIDRS FENCESTATE AGE RESULT
      network-fence-sample rook-ceph.cephfs.csi.ceph.com ["10.90.89.66/32","11.67.12.42/24"] Fenced 23s

@riya-singhal31 riya-singhal31 marked this pull request as ready for review December 12, 2023 14:17
@riya-singhal31
Copy link
Contributor Author

Should we backport this fix to 3.10?
@nixpanic , @Rakshith-R

@riya-singhal31
Copy link
Contributor Author

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 12, 2023 •
edited

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 51faa2a

@riya-singhal31
cephfs: fix network fencing admin id
e90aa48 
this commit replaces user id requirement with
admin id

Signed-off-by: Riya Singhal <rsinghal@redhat.com>
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Dec 12, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Dec 12, 2023
@riya-singhal31 riya-singhal31 mentioned this pull request Dec 12, 2023
Merged
6 tasks
@mergify mergify bot merged commit 51faa2a into ceph:devel Dec 12, 2023
34 checks passed
@Rakshith-R
Copy link
Contributor

riyasinghal@rsinghal-mac examples % kubectl get networkfences.csiaddons.openshift.io -o yaml apiVersion: v1 items:

  • apiVersion: csiaddons.openshift.io/v1alpha1
    kind: NetworkFence
    metadata:
    creationTimestamp: "2023-12-12T14:14:54Z"
    generation: 1
    name: network-fence-sample
    resourceVersion: "46073"
    uid: da427fd3-edf7-44bf-a0e5-dee0795c9399
    spec:
    cidrs:

    • 10.90.89.66/32
    • 11.67.12.42/24
      driver: rook-ceph.cephfs.csi.ceph.com
      fenceState: Fenced
      parameters:
      clusterID: rook-ceph
      secret:
      name: rook-csi-cephfs-provisioner
      namespace: rook-ceph
      kind: List
      metadata:
      resourceVersion: ""
      riyasinghal@rsinghal-mac examples % kubectl get networkfences.csiaddons.openshift.io
      NAME DRIVER CIDRS FENCESTATE AGE RESULT
      network-fence-sample rook-ceph.cephfs.csi.ceph.com ["10.90.89.66/32","11.67.12.42/24"] Fenced 23s

@riya-singhal31

There's no status/result field printed in this !
Please add the logs as requested in the associated issue.

cc @nixpanic

@nixpanic nixpanic added the backport-to-release-v3.10 Label to backport from devel to release-v3.10 branch label Dec 13, 2023
@mergify mergify bot mentioned this pull request Dec 13, 2023
Merged
@riya-singhal31
Copy link
Contributor Author

riya-singhal31 commented Dec 14, 2023 •
edited 

riyasinghal@rsinghal-mac examples % kubectl get networkfences.csiaddons.openshift.io 
NAME                   DRIVER                          CIDRS                                 FENCESTATE   AGE   RESULT
network-fence-sample   rook-ceph.cephfs.csi.ceph.com   ["10.90.89.66/32","11.67.12.42/24"]   Fenced       76s   



riyasinghal@rsinghal-mac examples % kubectl logs csi-cephfsplugin-provisioner-89696fcb6-md4j8 -c csi-addons -n rook-ceph
I1214 12:44:06.005375       1 client.go:79] Probing CSI driver for readiness
I1214 12:44:06.021437       1 server.go:90] Listening for CSI-Addons requests on address: [::]:9070

riyasinghal@rsinghal-mac examples % kubectl logs csi-cephfsplugin-provisioner-89696fcb6-md4j8 -c csi-provisioner -n rook-ceph
I1214 12:44:06.337282       1 csi-provisioner.go:154] Version: v3.6.2
I1214 12:44:06.337440       1 csi-provisioner.go:177] Building kube configs for running in cluster...
I1214 12:44:06.338375       1 common.go:138] Probing CSI driver for readiness
I1214 12:44:06.341137       1 csi-provisioner.go:302] CSI driver does not support PUBLISH_UNPUBLISH_VOLUME, not watching VolumeAttachments
I1214 12:44:06.341684       1 leaderelection.go:250] attempting to acquire leader lease rook-ceph/rook-ceph-cephfs-csi-ceph-com...


riyasinghal@rsinghal-mac examples % kubectl logs csi-cephfsplugin-provisioner-89696fcb6-md4j8 -c csi-cephfsplugin -n rook-ceph

The logs looks cleaner
cc: @Rakshith-R

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixpanic nixpanic nixpanic approved these changes

@yati1998 yati1998 yati1998 approved these changes

@parth-gr parth-gr parth-gr approved these changes

@Rakshith-R Rakshith-R Awaiting requested review from Rakshith-R

Assignees
No one assigned
Labels
backport-to-release-v3.10 Label to backport from devel to release-v3.10 branch bug Something isn't working component/cephfs Issues related to CephFS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cephfs: network fence does not work for cephfs
6 participants
@riya-singhal31 @ceph-csi-bot @Rakshith-R @nixpanic @yati1998 @parth-gr