Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resize issue #61

Closed
vatelzh opened this issue Dec 14, 2017 · 7 comments
Closed

resize issue #61

vatelzh opened this issue Dec 14, 2017 · 7 comments

Comments

@vatelzh
Copy link
Contributor

vatelzh commented Dec 14, 2017

Using gwcli to create rbd.disk1 with 10GB, and I want to resize it to 101GB, so I resize it as below:
/disks resize rbd.disk1 101G

I check the image info with rbd info disk1, and the size is 101GB.
I check the /sys/kernel/config/target/iscsi/
cat info
Status: ACTIVATED Max Queue Depth: 0 SectorSize: 512 HwMaxSectors: 128
Config: rbd/rbd/disk1;osd_op_timeout=30 Size: 108447924224

The problem is when I using iscsi initiator to login, I find the LUN size is still 10GB.
Is this a bug?

@mikechristie
Copy link
Contributor

Resize is broken right now.

On newer kernels it will work, but can cause hangs if the device is blacklisted.

On older kernels you will not see the size updated like above.

If you reboot the gws then the new size would take affect and the initiator would see it when the device is rescanned.

@pcuzner
Copy link
Collaborator

pcuzner commented Dec 15, 2017

@mikechristie should we disable resize for now to avoid issues with people testing?

@vatelzh
Copy link
Contributor Author

vatelzh commented Dec 15, 2017

On newer kernels it will work, but can cause hangs if the device is blacklisted.

@mikechristie which kernel version works? or which target patch should I apply in kernel?

@mikechristie
Copy link
Contributor

@pcuzer, yeah it is probably best to just disable for now.

@vatelzh, there is no fix done yet. For my comment about it working I should have been more specific. If you use the kernel and patches listed in the tcmu-runner 1.3.0rc4 release notes then it would work under really specific conditions. It is not safe to use right now.

@pcuzner
Copy link
Collaborator

pcuzner commented Dec 18, 2017

@mikechristie Ok. I have a patch for cli start up times, so once that's confirmed by vatelzh, let's get that merged, and then I'll drop resize out of the cli and api in a subsequent PR.

@mikechristie
Copy link
Contributor

@pcuzner Do not worry about disabling resize. The PRs:

ceph/ceph-iscsi-config#43
ceph/ceph-iscsi-config#27
open-iscsi/tcmu-runner#346

should fix all the known issues except the one where a initiator could race with us. It could be rescanning the size on each path at the same time we are updating and the initiator could end up with a mismatch on different paths. For that race you currently have to initiate manual resize on the initiator side.

@mikechristie
Copy link
Contributor

Resize should be working in the current release. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants