Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting locks #27

Closed
immesys opened this issue Aug 3, 2016 · 5 comments
Closed

Supporting locks #27

immesys opened this issue Aug 3, 2016 · 5 comments

Comments

@immesys
Copy link
Contributor

immesys commented Aug 3, 2016 •
edited

Is it possible to add support for the rados locking functions (like rados_lock_exclusive)? I'm porting code from using librados via CGO directly to using this go library, but I would like to use these functions.

Thanks!
@dotnwat
Copy link
Contributor

dotnwat commented Aug 3, 2016

Definitely. The fastest way is to submit a pull request (making the wrappers is really fast). Otherwise I'll stick this on the TODO list :)

@immesys
Copy link
Contributor Author

immesys commented Aug 3, 2016

Sure, I'll tackle this today or tomorrow and submit the PR.

@dotnwat
Copy link
Contributor

dotnwat commented Aug 3, 2016

It looks like there is PR that I lost track of that is looking at object locking. It has a merge conflict. Perhaps the only thing that needs to be done is just checkout that PR and make sure it works and fix the conflict? #26

@immesys
Copy link
Contributor Author

immesys commented Aug 3, 2016

done

@immesys
Copy link
Contributor Author

immesys commented Dec 30, 2016

Closing this, the PR was merged and has been working for months.

@immesys immesys closed this as completed Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dotnwat @immesys