Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the fixturenet eth tests more robust #581

Open
dboreham opened this issue Oct 13, 2023 · 0 comments
Open

Make the fixturenet eth tests more robust #581

dboreham opened this issue Oct 13, 2023 · 0 comments

Comments

@dboreham
Copy link
Collaborator

Currently the fixturenet-{plugeth-}eth tests discriminate the result by mean of a check that the chain block height advances over a time interval. The idea being that if the chain isn't working, there either won't be a block height, or it will be stuck at zero (or possibly some other number close to zero).

Problem is that the current code for making this determination is sensitive to timing. It just waits a fixed number of seconds. On a slow test runner this time can be too short. But we don't want the test to take forever to run on a fast machine.

It would be better if the block height check was done in a polling loop -- check for a height, if none found wait a bit then check again. Keep doing that for some fairly long time. Then same thing for checking for the second block height. Using this approach the test would adapt to the speed of the runner and only take a long time on a slow machine, or in the event the test is going to fail (because the block height never advances).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant