Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger time adds promise execution time as well #8

Closed
ksmth opened this issue May 19, 2015 · 5 comments
Closed

Debugger time adds promise execution time as well #8

ksmth opened this issue May 19, 2015 · 5 comments

Comments

@ksmth
Copy link

ksmth commented May 19, 2015

When I watched one of your tutorials on YouTube, I think I noticed that the debugger added the execution time of promises as well. The way I understood the purpose of the shown value was, that it is used to determine, whether your app is fast enough.

Is it still accurate, when the promises are included?

@christianalfoni
Copy link
Member

Actually it does not compute the complete signal, but each action is computed. But if an action is async it does not really matter to compute the next actions because now you are running on a new animation frame again. BTW, note to self. After async action it does not wait for next animation frame, which it should.

Anyways, I am not quite sure how to display a duration of a signal when parts of it is async. Maybe show duration on each action instead and just the accumulated result at the top?

@ksmth
Copy link
Author

ksmth commented May 22, 2015

Maybe you visualize which actions took place in what animation frame an sum that up?

+------------------------------------+
| app mounted (34ms)                 | <--- total
|+----------------------------------+|
|| 12ms                             || <--- everything up to the next async
|| - 1. setLoadingProjects -        ||
|+----------------------------------+|
|+----------------------------------+|
|| 26ms                             || <--- next group
|| - 2. getProjects (async) -       ||
|| - 3. setProjects -               ||
|| - 4. setProjectRows -            ||
|+----------------------------------+|
+------------------------------------+

@christianalfoni
Copy link
Member

Yeah, that would look awesome, have to wait until I get next release out first though. But will work on it next. Great suggestion, thanks!

@christianalfoni
Copy link
Member

Want to get a new release out before going into this stuff. It required quite a bit of work and there are more urgent matters to attend, though it will be implemented later :-)

@christianalfoni
Copy link
Member

Duration is now fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants