Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all fields of relationship #1321

Closed
2 of 7 tasks
rusikf opened this issue Apr 14, 2020 · 1 comment
Closed
2 of 7 tasks

Include all fields of relationship #1321

rusikf opened this issue Apr 14, 2020 · 1 comment

Comments

@rusikf
Copy link

rusikf commented Apr 14, 2020

This issue is a (choose one):

  • Problem/bug report.
  • Feature request.
  • Request for support. Note: Please try to avoid submitting issues for support requests. Use Gitter instead.

Checklist before submitting:

  • I've searched for an existing issue.
  • I've asked my question on Gitter and have not received a satisfactory answer.
  • I've included a complete bug report template. This step helps us and allows us to see the bug without trying to reproduce the problem from your description. It helps you because you will frequently detect if it's a problem specific to your project.
  • The feature I'm asking for is compliant with the JSON:API spec.

Description

I have

 class PostResource < JSONAPI::Resource
   attributes :title, :content, :published
    has_many :comments, always_include_linkage_data: true
  end

class CommentResource < JSONAPI::Resource
   attributes :content, :post_id
     belongs_to :post, optional: true
   end

How to include comments all fields? I can include it via /posts?include=comments
But this, include comments separately in response 'include' field

Is it possible to include it directly in post relationships?


"relationships": {
"comments": {
"data": [
{
"type": "comments",
"id": "1",
 # here I want comment content
}
}

}

@scottgonzalez
Copy link
Collaborator

scottgonzalez commented Apr 14, 2020

What you're asking for does not comply with JSON:API. See https://jsonapi.org/format/#fetching-includes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants