Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require jsonapi/resource_controller in main file? #59

Closed
barelyknown opened this issue Jan 20, 2015 · 4 comments
Closed

Require jsonapi/resource_controller in main file? #59

barelyknown opened this issue Jan 20, 2015 · 4 comments

Comments

@barelyknown
Copy link
Collaborator

jsonapi/resource_controller is not required in the main, but it feels like it should be. How do you feel about making that change?

@lgebhardt
Copy link
Member

@barelyknown I think that makes sense. But I'd like to get active_record_operations_processor out of the required list for jsonapi/resource_controller at the same time. Ideally JR would be agnostic on the choice of ORM. As it is now it's closely tied to ActiveRecord. I think that's the reason I left jsonapi/resource_controller out.

@barelyknown
Copy link
Collaborator Author

OK. Maybe wait until it's agnostic to make that change then. It's not a big deal to require it in the controller, but I just wanted to make things easier for new users.

@lgebhardt
Copy link
Member

I agree that it would make things easier for new users. I hope to get back to the ORM issue (#51) soon.

@barelyknown
Copy link
Collaborator Author

Closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants