Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake FindPackage Python to allow Python3 on macOS #92

Closed
Axel-Naumann opened this issue Mar 16, 2022 · 7 comments
Closed

Update CMake FindPackage Python to allow Python3 on macOS #92

Axel-Naumann opened this issue Mar 16, 2022 · 7 comments

Comments

@Axel-Naumann
Copy link

Current macOS does not come with python 2 anymore. CMake should be updated to use the new FindPackage Python, similar to what's done here: https://github.com/dpiparo/vdt/pull/12/files - that will happily find Python3.

This blocks building ROOT on current macOS systems, version 12.3.

@mpatrascoiu
Copy link
Contributor

Hello Axel,

Thanks for bringing this up. Commit 96fbb96 should fix it.
It will be released in davix-0.8.1.

Cheers,
Mihai

@Axel-Naumann
Copy link
Author

Excellent, thank you, Mihai! Do you have an ETA for 0.8.1?

@mpatrascoiu
Copy link
Contributor

I knew this question would show up.

I want to also merge #83 , but that change is also tied to gfal2 v2.21.0 upcoming release, which we don't expect until a month or so.

@Axel-Naumann
Copy link
Author

Thanks. The current Davix release does not build anymore on macOS 12; this PR unblocks that. We need to release a patch release of ROOT 6.26 to address this (among other things). I'd very much prefer to use a Davix tag, rather than using the previous Davix release plus this issue's commit. If it's reasonably simple to create a release (e.g. for ROOT it's quite involved...) could I propose to have 0.8.1 released "now" and the gfal PR in a subsequent release - also given its dependence on another library and its schedule? FYI @gganis

@mpatrascoiu
Copy link
Contributor

Hello Axel,

Thanks for letting me know on the ROOT plans. Sure, there is a way to move forward and I think we can provide davix 0.8.1 within this week.

Cheers,
Mihai

@Axel-Naumann
Copy link
Author

Wow that would be fantastic - thank you so much!

@mpatrascoiu mpatrascoiu changed the title Update CMake FindPackage Python to allow Python3 Update CMake FindPackage Python to allow Python3 on macOS Mar 30, 2022
@mpatrascoiu
Copy link
Contributor

Hello Axel,

Davix 0.8.1 has been released.
Please find the RPMs in the official DMC repository.

Cheers,
Mihai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants