Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accumulator record has apparently unused field #287

Closed
WilliamParker opened this issue May 1, 2017 · 2 comments
Closed

Accumulator record has apparently unused field #287

WilliamParker opened this issue May 1, 2017 · 2 comments
Labels
maintenance
Milestone
0.15.0

Comments

@WilliamParker
Copy link
Collaborator

The Accumulator record has a field "input-condition" that doesn't seem to be used anywhere based on this search. According to Git Blame the line dates back to this early refactoring commit. A quick glance through the code then suggests that the structure of accumulation in the rules network was significantly different then. @rbrush I think that field can be removed from the accumulator record definition?
@rbrush
Copy link
Contributor

rbrush commented May 1, 2017

Yes, I think this can be safely removed for the reasons you mention.

@WilliamParker
Copy link
Collaborator Author

Addressed by 0d93842

Closing.

@WilliamParker WilliamParker added this to the 0.15.0 milestone May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
2 participants
@rbrush @WilliamParker