Issue 102: Prevent AccumulateNode from creating binding groups when t… #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…here are no corresponding elements
WilliamParker
force-pushed
the
issue102-AccumulateNode
branch
from
0005bd0
to
3741438
Compare
|
I've updated this on top of master after the merge of #206 We can merge this now, after you've looked at it and assuming you agree with the changes of course, and I can then put in tests for this using the new generators later. Alternatively, we can hold off entirely until generative tests are written; either works. I'm personally slightly biased toward merging so all work can proceed from the same baseline, but I'm not aware of any work where having these changes in would be particularly beneficial. |
|
I'll get this merged shortly; just poking around it a bit first. |
|
No problem, I don't want to pressure you into merging without looking things over first. :) |
|
Alright, merged! Thanks for all of your work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…here are no corresponding elements