Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Ignore folders such as node_modules when looking for feature files #46

Open
jkuester opened this issue Jan 8, 2020 · 3 comments
Open

Comments

@jkuester
Copy link
Collaborator

jkuester commented Jan 8, 2020

Currently, when the user selects a directory, CFD will crawl through all sub-directories looking for *.feature files. This can cause problems. For example, if a Node project has a dependency that includes feature files those feature files can show up in the node_modules folder. Then, if someone uses CFD to generate a report for the original Node project, CFD will also include the features from the dependency in the generated report.

There is probably a list of directories (including node_modules) that we could hard-code and ignore.

An alternative option would be to try and parse SCM metadata (e.g. the .gitignore file) and just ignore what it ignores....

@TobiTenno
Copy link
Member

sounds like a good idea to me

@jkuester jkuester transferred this issue from cerner/cucumber-forge-desktop May 4, 2020
@jkuester
Copy link
Collaborator Author

jkuester commented May 4, 2020

Now that the generator, itself, is responsible for loading the feature files from the directories, it seems like this issue belongs here and not in cucumber-forge-desktop.

It is also worth noting that #41 has already implemented the first part of this issue by excluding feature files from the target and node_modules directories. I am leaving this issue open in case we ever decide to make the generator "git aware" and ignore based on something like the .gitignore file.

@TobiTenno
Copy link
Member

could even enforce our own file so it wouldn't get too convoluted.... or just support a list of specific types, like git being the main one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants