Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-responsive-element] Consume terra-breakpoints and update size props #2048

Closed
tbiethman opened this issue Nov 13, 2018 · 0 comments · Fixed by #2452
Closed

[terra-responsive-element] Consume terra-breakpoints and update size props #2048

tbiethman opened this issue Nov 13, 2018 · 0 comments · Fixed by #2452

Comments

@tbiethman
Copy link
Contributor

Feature Request

Description

The ResponsiveElement has historically defined its own breakpoint values. However, the terra-breakpoints package was recently created to contain any and all things breakpoint related. The ResponsiveElement should consume breakpoint values from that package and remove any files that are defining breakpoint values internally.

The creation of terra-breakpoints also saw the redefinition of some of our breakpoint names. The ResponsiveElement's props should be updated to reflect those new values.

These will be breaking changes, but they are necessary to bring the component into alignment with our breakpoint strategy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants