Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Add src to .npmignore #78

Closed
1 task done
bjankord opened this issue Mar 3, 2017 · 3 comments
Closed
1 task done

Add src to .npmignore #78

bjankord opened this issue Mar 3, 2017 · 3 comments

Comments

@bjankord
Copy link
Contributor

bjankord commented Mar 3, 2017

Description of Issue

A common pattern for npm modules is to add the lib(es5) directory to the .gitignore and add the src(es6) directory to the .npmignore. Babel is an example of this pattern that also uses lerna.

More information can be found in this article:
http://jamesknelson.com/writing-npm-packages-with-es6-using-the-babel-6-cli/

  • Add a .npmignore file to each package that contains the src directory.
@Matt-Butler
Copy link
Contributor

Blocked on cerner/terra-ui#98

@bjankord
Copy link
Contributor Author

bjankord commented May 4, 2017

This is partially complete now with #295 resolved. We've talked about not adding lib to .gitignore as we use files in lib with terra-site to do some testing. I think its possible we could add lib to .gitignore, we'd just want to generate those files whenever we run tests that reference them.

I'm thinking we close this and open a new issue for discussing what we want to do with lib. @Matt-Butler what are your thoughts?

@Matt-Butler
Copy link
Contributor

Matt-Butler commented May 5, 2017

+1 to adding a new issue to add lib to the .gitignore

#316

@Matt-Butler Matt-Butler changed the title Add lib directory to .gitignore. Add src to .npmignore Add src to .npmignore May 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants