Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the consumer to skip the mounting lifecycle so that he can reuse the same frame #7

Closed
sdivi opened this issue Oct 21, 2017 · 4 comments

Comments

@sdivi
Copy link

sdivi commented Oct 21, 2017

Please fill out the below template as best you can.

Description of Issue

As a consumer of xfc i should be able to skip the mounting lifecycle so that i can reuse the same iframe and go through the remaining life cycle events of xfc launched and authorized so that i can skip the costly iframe creation operation

System Configuration

Project Version

Additional Details (optional)

In a use case where we launch the provider using xfc initial life cycle events and in a refresh scenario where we launch the provider with same url with different authentication params i should be able to use the existing frame and go through the launched and authorized state

Steps to Reproduce the Issue

  1. Launch any provider using xfc lifecycle events which will create a frame. Relaunch the same content provider which will create a new frame

Expected Outcomes

Ability to reuse the frame by skipping the mounting lifecycle event and go through the remaining lifecycle events

@sdivi
Copy link
Author

sdivi commented Oct 21, 2017

@poloka

@mhemesath
Copy link
Contributor

This seems like a reasonable feature to add. If you open a pull request I’d be happy to review and merge it. Thanks!

@kafkahw
Copy link
Contributor

kafkahw commented Oct 25, 2017

This issue will be addressed by this PR #8

@kafkahw
Copy link
Contributor

kafkahw commented Oct 27, 2017

Fixed in PR #8

@kafkahw kafkahw closed this as completed Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants