Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate bug in the H5P update script #455

Closed
tmkarlsen opened this issue Jan 13, 2022 · 3 comments
Closed

Investigate bug in the H5P update script #455

tmkarlsen opened this issue Jan 13, 2022 · 3 comments
Labels
bug Something isn't working investigate Initial investigation up until 30 minutes before further action is agreed.

Comments

@tmkarlsen
Copy link
Member

tmkarlsen commented Jan 13, 2022

Describe the bug
When updating library versions on H5P-resources, some libraries experience both or one of the following errors:

  1. The H5P title is overwritten with data from the next input field (E.g. Documentation Tool)
  2. The data within H5P "Metadata" is dropped

Affected libraries
These are the ones documented so far:

  • Single Choice: error 1 (title is overwritten)
  • Dialog Cards: error 1 and 2 (title is overwritten + metadata is emptied)
  • Documentation Tool: error 1 and 2 (title is overwritten + metadata is emptied)
  • Find the hotspot: error 1 (title is overwritten)
  • True/false: error 1 (title is overwritten)
  • Column: error 1 (title is overwritten)

To Reproduce
Steps to reproduce the behavior:

  1. Find an old Documentation tool within "Shared content"'
  2. Edit, verify and document the attribution data in the H5P "Metadata" and the title of the resource
  3. Choose the latest upgrade version and upgrade (Note: do not save and close after the upgrade has run)
  4. Verify that the title has been changed and the metadata dropped.

Expected behavior
Title and metadata (like anything else) should not be affected by version upgrades of H5P-resources

Screenshots

Note: the update of this Documentation Tool was done from a 1.6.x version to 1.8.9

Skjermbilde 2022-01-13 kl  10 38 04

Skjermbilde 2022-01-13 kl  10 38 30

Skjermbilde 2022-01-13 kl  10 37 53

Skjermbilde 2022-01-13 kl  10 37 42

@tmkarlsen tmkarlsen added bug Something isn't working needs triage All issues that need to be triaged by repository admins labels Jan 13, 2022
@tmkarlsen tmkarlsen added this to To do in NDLA via automation Jan 13, 2022
@tmkarlsen tmkarlsen added this to To do in Edlib via automation Jan 13, 2022
@tmkarlsen tmkarlsen removed this from To do in NDLA Jan 13, 2022
@tmkarlsen tmkarlsen removed this from To do in Edlib Jan 13, 2022
@tmkarlsen tmkarlsen added this to To do in NDLA via automation Jan 13, 2022
@tmkarlsen tmkarlsen added this to To do in Edlib via automation Jan 19, 2022
@tmkarlsen
Copy link
Member Author

Doc.tool:
https://github.com/h5p/h5p-documentation-tool/blob/master/upgrades.js
Seemes like the updating of title from the upgrade.js clears out all existing data in the metadata section.
We need to verify if this is because of the way we add the author or not.

True/false:
https://github.com/h5p/h5p-true-false/blob/master/upgrades.js

@tmkarlsen tmkarlsen moved this from To do to In progress in NDLA Jan 21, 2022
@tmkarlsen tmkarlsen moved this from To do to In progress in Edlib Jan 26, 2022
@maxmoeschinger
Copy link
Contributor

@tmkarlsen er dette noe som Joubel jobber med?

@maxmoeschinger maxmoeschinger removed the needs triage All issues that need to be triaged by repository admins label Feb 1, 2022
@tmkarlsen
Copy link
Member Author

@maxmoeschinger we have created an issue on one of their repos' regarding this, yes.
h5p/h5p-documentation-tool#47

NDLA automation moved this from In progress to Done Feb 1, 2022
Edlib automation moved this from In progress to Done Feb 1, 2022
@tmkarlsen tmkarlsen added the investigate Initial investigation up until 30 minutes before further action is agreed. label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working investigate Initial investigation up until 30 minutes before further action is agreed.
Projects
No open projects
Edlib
Done
NDLA
Done
Development

No branches or pull requests

2 participants