Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Issuer as not ready if DNS provider credentials are invalid #32

Closed
munnerz opened this issue Aug 7, 2017 · 3 comments
Closed

Mark Issuer as not ready if DNS provider credentials are invalid #32

munnerz opened this issue Aug 7, 2017 · 3 comments
Labels
area/acme Indicates a PR directly modifies the ACME Issuer code kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@munnerz
Copy link
Member

munnerz commented Aug 7, 2017

Right now we begin attempting authorisations for domains that need authorising before we've validated the configuration in the Issuer/Certificate resource.

We should make sure we perform the least interaction possible with the ACME server to prevent hitting any rate limits. In the case of DNS01, this could be done during the Issuers Setup step (where the status.ready field can be set to false if DNS provider credentials are invalid/not specified).
@retest-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle stale

@jetstack-bot jetstack-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 5, 2018
@munnerz munnerz changed the title Check provider configuration is valid before attempting authorisations Mark Issuer as not ready if DNS provider credentials are invalid Jun 5, 2018
@munnerz
Copy link
Member Author

munnerz commented Jun 5, 2018

/lifecycle frozen
/remove-lifecycle stale

@jetstack-bot jetstack-bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 5, 2018
@munnerz munnerz added area/acme Indicates a PR directly modifies the ACME Issuer code kind/feature Categorizes issue or PR as related to a new feature. labels Jun 5, 2018
@munnerz
Copy link
Member Author

munnerz commented Nov 26, 2018

Related to #783 - with #783, we could add a Ready condition to solvers and allow each solver to define its own 'readiness' accordingly

@munnerz munnerz closed this as completed Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/acme Indicates a PR directly modifies the ACME Issuer code kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@munnerz @jetstack-bot @retest-bot