Remove pkg/util/coverage #5032
Merged
Remove pkg/util/coverage #5032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
kind/bug
|
/test pull-cert-manager-make-test |
|
/test pull-cert-manager-make-e2e-v1-23 |
davidsbond
approved these changes
Apr 8, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidsbond, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
SgtCoDFish
force-pushed
the
contributorempathy
branch
from
0fb0bfa
to
76cdab0
Compare
|
/lgtm |
|
Note: there are a few references to this stuff in bazel code dotted around, but it doesn't look like this removal should break anything. If it does, I'll remove those other references too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Motivation
Fixes #5029
We shouldn't use https://pkg.go.dev/testing#MainStart anywhere since it's not subject to the Go 1.x compat guarantee. Fixing this is gonna be a pain, so just remove it.
Kind
/kind bug
Release Note