Bump Go to 1.18

[lucacome]

Signed-off-by: Luca Comellini luca.com@gmail.com

Pull Request Motivation

Bumps Go from 1.17 to 1.18.
Also updates rules_go and bazel_gazelle for Bazel.

Kind

/kind cleanup

Release Note

Bump cert-manager's version of Go to 1.18

[jetstack-bot]

Hi @lucacome. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lucacome]

/assign @irbekrm

[irbekrm]

Thank you for the PR!

/ok-to-test

[irbekrm]

/test pull-cert-manager-e2e-v1-23

[irbekrm]

Thanks for the PR! Before we merge this, somebody should go through the release notes and check for any changes potentially related to our codebase https://go.dev/doc/go1.18
If you'd like to have a go feel free, but appreciate that it might be proportionally a lot of work with a less familiar codebase

[irbekrm]

I've read through Go 1.18 release notes, does not look like there is anything that would affect our codebase.

Some thoughts (not related to this PR's contents):

• It would be interesting to see if we can utilize some of the new fuzzing functionality to test our API types (we currently use https://github.com/google/gofuzz)
• some changes about what information is available for build binaries via go version-,go%20version,-The%20go%20command) - all looks like useful information, we can check it out once we've built the first alpha with this
• some garbage collector changes-,Runtime,-The%20garbage%20collector) - it will be interesting to see if there are any changes in memory consumption
• compiler changes seem to suggest we might have slower builds with this version of Go
• smaller binaries 🥳
• minimum default TLS version in Go 1.18 is now 1.2- this does not affect us as we are already explicitly defaulting to 1.2 as minimum version (in our webhook)
• SHA-1 is now rejected by go/crypto - we did not accept that anyway
• safer implementations of elliptic curves 🥳
• some ideas how we could utilize the new workspace functionality here

The only small nit is that we should remove the // +build lines here and here as those are now obsolete- @lucacome I'm adding a 'hold' in case you like to do that in this PR else we can merge as is

/lgtm
/approve
/hold

[irbekrm]

/test pull-cert-manager-make-e2e-v1-24
/test pull-cert-manager-e2e-feature-gates-disabled
/test pull-cert-manager-e2e-v1-20
/test pull-cert-manager-e2e-v1-21
/test pull-cert-manager-e2e-v1-22
/test pull-cert-manager-e2e-issuers-venafi-cloud
/test pull-cert-manager-issuers-venafi-tpp

[irbekrm]

Actually this will not pass now as we have some infra issues. The Venafi Cloud one passes though, so that should be ok

/override pull-cert-manager-issuers-venafi-tpp

[jetstack-bot]

@irbekrm: Overrode contexts on behalf of irbekrm: pull-cert-manager-issuers-venafi-tpp

In response to this:

Actually this will not pass now as we have some infra issues. The Venafi Cloud one passes though, so that should be ok

/override pull-cert-manager-issuers-venafi-tpp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[irbekrm]

known flake

/test pull-cert-manager-e2e-feature-gates-disabled

[lucacome]

@irbekrm I've removed // +build and ran go fix. I've left it in a different commit to make it easier to see the changes, because I think something's off with bazel but I'm not 100% sure.
Also go fix fixed unrelated stuff that I don't know if we want to include in this PR.

EDIT: I see that the build is failing because of the changes in bazel

[lucacome]

/retest

[lucacome]

/retest

[irbekrm]

Thanks for making the changes! I think it's just the goimports that is failing - left a comment for that.

[lucacome]

@irbekrm I've reverted the change and added back // +build tools in tools.go since it was making Bazel fail.

[lucacome]

/retest

[irbekrm]

Thanks @lucacome !

/lgtm
/approve

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, lucacome

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [irbekrm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[irbekrm]

/hold cancel