Don't require python to be installed for everything #5245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
release-note
SgtCoDFish
force-pushed
the
noglobalpython
branch
from
d3131aa
to
93c7867
Compare
We only use python in one place and probably won't start using it more without some kind of policy change. We don't need to require that everyone has it installed, and can instead only require it for people who're running the boilerplate check Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
SgtCoDFish
force-pushed
the
noglobalpython
branch
from
93c7867
to
2c9344e
Compare
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
SgtCoDFish
commented
Jun 28, 2022
| ## make kind [KIND_CLUSTER_NAME=name] [K8S_VERSION=<kubernetes_version>] | ||
| ## make [KIND_CLUSTER_NAME=name] [K8S_VERSION=<kubernetes_version>] e2e-setup-kind |
There was a problem hiding this comment.
note: unrelated change, but I noticed this comment was wrong and wanted to fix it quickly!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakexks, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only use python in one place and probably won't start using it more without some kind of policy change.
We don't need to require that everyone has it installed, and can instead only require it for people who're running the boilerplate check.
Kind
/kind cleanup
Release Note