Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate AdditionalCertificateOutputFormats feature gate #6356

Closed
erikgb opened this issue Sep 23, 2023 · 5 comments · Fixed by #6970
Closed

Graduate AdditionalCertificateOutputFormats feature gate #6356

erikgb opened this issue Sep 23, 2023 · 5 comments · Fixed by #6970
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@erikgb
Copy link
Contributor

erikgb commented Sep 23, 2023

Is your feature request related to a problem? Please describe.

The feature gate AdditionalCertificateOutputFormats was introduced in cert-manager 1.7.0 and we have been using it since then without any issues. I also have a feeling it unlocks a feature needed by multiple cert-manager users. We are heavy users of Kafka, and to avoid the pesky keystores/truststores we need this feature to provide an alternative PEM "keystone" format accepted by Kafka.

We try to avoid enabling feature gates, especially features marked as alpha features. But in this case we had no choice.

Describe the solution you'd like

I would like to see this feature gate graduated, ref. https://cert-manager.io/docs/installation/featureflags/#graduation. First to Beta and enabled by default and eventually removed.

Describe alternatives you've considered

Additional context

Environment details (remove if not applicable):

  • Kubernetes version:
  • Cloud-provider/provisioner:
  • cert-manager version:
  • Install method: e.g. helm/static manifests

/kind feature

@jetstack-bot jetstack-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 23, 2023
@inteon
Copy link
Member

inteon commented Oct 11, 2023

Feel free to create a PR to promote this feature to beta. See #6298 as example.

@jetstack-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle stale

@jetstack-bot jetstack-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2024
@erikgb
Copy link
Contributor Author

erikgb commented Jan 9, 2024

/remove-lifecycle stale

I am (still) planning to do this. 😅

@jetstack-bot jetstack-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2024
@jetstack-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale

@jetstack-bot jetstack-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 8, 2024
@inteon
Copy link
Member

inteon commented Apr 8, 2024

/remove-lifecycle stale

@jetstack-bot jetstack-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants