Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 'IsCA' flag on Certificate resource #85

Closed
munnerz opened this issue Sep 11, 2017 · 5 comments
Closed

Support 'IsCA' flag on Certificate resource #85

munnerz opened this issue Sep 11, 2017 · 5 comments
Labels
area/api Indicates a PR directly modifies the 'pkg/apis' directory kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@munnerz
Copy link
Member

munnerz commented Sep 11, 2017 •
edited

In order to allow for auto-setup of a CA based issuer using self signed certificates, we should allow the Certificate specification to specify whether this Certificate is an issuing CA.

ref #83 #84

/area api
/kind feature
This was referenced Sep 11, 2017
Closed
Open
Closed
@whereisaaron
Copy link
Contributor

The 'CA' flag applies to both root and intermediate certificates. So I think 'isCA' and 'isSelfSigned' are two different things?

@munnerz
Copy link
Member Author

munnerz commented Sep 13, 2017

@whereisaaron sorry, the original issue wasn't clear.

#84 is tracking adding self signed certificates support. This is specifically just for adding the isCA field, which is required in order for us to later support #83. My thoughts here are that a user can create a Certificate resource with isCA set to true, and the issuer set to selfsigned.

@jetstack-bot jetstack-bot added area/api Indicates a PR directly modifies the 'pkg/apis' directory kind/feature Categorizes issue or PR as related to a new feature. labels Oct 23, 2017
@munnerz munnerz mentioned this issue Feb 5, 2018
Open
@retest-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Send feedback to jetstack.
/lifecycle stale

@jetstack-bot jetstack-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 5, 2018
@munnerz munnerz added area/ca Indicates a PR directly modifies the CA Issuer code lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. area/ca Indicates a PR directly modifies the CA Issuer code labels Jun 5, 2018
@zwtj
Copy link

zwtj commented Sep 11, 2018

Hi, just wanna ask if this issue is still considered to be implemented?

@munnerz
Copy link
Member Author

munnerz commented Sep 11, 2018

Yep, this will be in the v0.5 release 😄

@munnerz munnerz closed this as completed Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api Indicates a PR directly modifies the 'pkg/apis' directory kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@munnerz @whereisaaron @jetstack-bot @zwtj @retest-bot