Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete regular expression for hostnames #48

Closed
wangli1030 opened this issue Apr 10, 2024 · 1 comment · Fixed by #66
Closed

Incomplete regular expression for hostnames #48

wangli1030 opened this issue Apr 10, 2024 · 1 comment · Fixed by #66

Comments

@wangli1030
Copy link
Contributor

wangli1030 commented Apr 10, 2024

in internal/versionchecker/fromservice.go:28
var imageVersion = regexp.MustCompile(``^quay.io/jetstack/cert-manager-webhook:(v(?:\d+)\.(?:\d+)\.(?:\d+)(?:.*))$``)
the dot before 'io' shoule be escaped, otherwise, it will have potential risk to match more hosts.

@wangli1030
Copy link
Contributor Author

I will raise PR to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant