cant install chart v0.5.0

[isality]

h1 there

i cant install v0.5.0. I got error:

Error: template: cert-manager-istio-csr/templates/serviceaccount.yaml:3:7: executing "cert-manager-istio-csr/templates/serviceaccount.yaml" at <ne .Values.image.pullSecretName "">: error calling ne: incompatible types for comparison

Use --debug flag to render out invalid YAML

I added pullSecretName: "" in values.yaml, object image and helm template works fine. Could your check this?

[JoshVanL]

Hi @isality, this looks to be a duplicate of #175
Can you update your helm version, and try again?

[isality]

H1!

I updated helm to version.BuildInfo{Version:"v3.9.3", GitCommit:"414ff28d4029ae8c8b05d62aa06c7fe3dee2bc58", GitTreeState:"clean", GoVersion:"go1.17.13"}

And right now i can do helm template istio-csr ./

---
# Source: cert-manager-istio-csr/templates/serviceaccount.yaml
apiVersion: v1
kind: ServiceAccount
imagePullSecrets:
  - name: 
metadata:
  labels:
    app.kubernetes.io/name: cert-manager-istio-csr
    helm.sh/chart: cert-manager-istio-csr-v0.5.0
    app.kubernetes.io/instance: istio-csr
    app.kubernetes.io/version: "v0.5.0"
    app.kubernetes.io/managed-by: Helm
  name: cert-manager-istio-csr

But i think it's not okay, when a non-existent field is accessed. See https://github.com/cert-manager/istio-csr/blob/v0.5.0/deploy/charts/istio-csr/templates/serviceaccount.yaml#L3

Thx

[JoshVanL]

Could you explain this a bit more, I’m not sure I follow?

But i think it's not okay, when a non-existent field is accessed

[isality]

Ok, see

Your trying to get value .Values.image.pullSecretName here, but in values.yaml your haven't a field pullSecretName in object image.

[nitishkrishna]

+1 seeing the same issue, its referring to a non-existing value

[craigmunro]

Same problem here. I've raised #182 to fix