Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to s390x arch #300

Closed
dilipgb opened this issue Feb 21, 2024 · 9 comments
Closed

Add support to s390x arch #300

dilipgb opened this issue Feb 21, 2024 · 9 comments

Comments

@dilipgb
Copy link

dilipgb commented Feb 21, 2024

trust manager tool is currently supported for amd, arm and power architectures. We need to enable the trust manager on s390x architecture as well.

@rishikakedia
Copy link
Contributor

#315 here is PR for this issue. Please review.

@SgtCoDFish
Copy link
Member

It's worth saying here that we won't be testing trust-manager on s390x any time soon. I don't see much harm in adding support for it (since it's easy in go!) but it'll be similar to cert-manager in that we won't actually test much on s390x!

@SgtCoDFish
Copy link
Member

Quick question for you both; in #315 @rishikakedia says this:

This is pre-req required for trust bundle integration for knative eventing.

Why does knative eventing require s390x in this case? Does knative require a set of architectures to be supported?

I've not really used knative at all, so I'm curious to learn more!

@dilipgb
Copy link
Author

dilipgb commented Mar 6, 2024

@SgtCoDFish we are working on porting knative to s390x. We are knative on s390x and not the other way knative needs s390x. trust manager and cert manager is one of the dependency to enable for s390x.

@SgtCoDFish
Copy link
Member

Ah I see! That's fair enough. I'm fairly happy to add new arches if there's demand for them - s390x was left off because we'd not seen much demand.

@dilipgb
Copy link
Author

dilipgb commented Mar 6, 2024

@SgtCoDFish Thank you for the quick action on this.

@SgtCoDFish
Copy link
Member

My pleasure, thank you for getting involved! I'll close this now since the PR merged; should be doing a new trust-manager release this week too!

@dilipgb
Copy link
Author

dilipgb commented Mar 7, 2024

@SgtCoDFish please excuse me for commenting on closed issue. I didn't find any channel related in cncf slack, hence using the same thread and not creating multiple issues.

We had one request regarding trust-manager-package-debian image referred. Can we get it published for s390x as well? We are facing issue with init containers. We tried building locally using command make trust-package-debian-save DEBIAN_TRUST_PACKAGE_VERSION="latest" and that works fine. I assume this is where the image is getting built, please correct me if I'm wrong.

@SgtCoDFish
Copy link
Member

Ah it's absolutely OK to comment here! For future reference, we're on Kubernetes slack: https://cert-manager.io/docs/contributing/#slack

I totally didn't think about the Debian package! I'll see what I can do about that tomorrow, hopefully we should be able to get one published pretty quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants