Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid multiple decode/encode of certificates #305

Open
erikgb opened this issue Feb 26, 2024 · 9 comments
Open

Avoid multiple decode/encode of certificates #305

erikgb opened this issue Feb 26, 2024 · 9 comments
Assignees

Comments

@erikgb
Copy link
Contributor

erikgb commented Feb 26, 2024

          I have a feeling we are decoding/encoding certs in bundles multiple times already, and this adds another round of decode/encode. What about using a "Cert Pool" as an intermediate format between functions - instead of `[]string` or `[]byte`? We could fix this in a follow-up PR. Just wanted to note it here.

Originally posted by @erikgb in #303 (comment)

@arsenalzp
Copy link
Contributor

Hello,
Can I work on this?
If we have the final decision, I cat work on this issue to improve code usage and performance.
I would appreciate any suggestions how can we improve.
As far as I remember CertPool usage was suggested.

@erikgb
Copy link
Contributor Author

erikgb commented Apr 8, 2024

Please do, @arsenalzp! 🎉 Anything that needs to be decided?

@arsenalzp
Copy link
Contributor

Please do, @arsenalzp! 🎉 Anything that needs to be decided?

As usually, during the work process we finding out the best decision :)

@arsenalzp
Copy link
Contributor

/assign

@erikgb
Copy link
Contributor Author

erikgb commented May 15, 2024

@arsenalzp Are you working on this issue? If not, I am considering to take a stab. 🤠

@arsenalzp
Copy link
Contributor

@arsenalzp Are you working on this issue? If not, I am considering to take a stab. 🤠

Hello,
Sure, I don't forget about this issue, however I pushed all my strengths to pass one of AWS Architect exam.
Please, don't re-assign this issue to anyone else, I will manage with it soon :)

@arsenalzp
Copy link
Contributor

arsenalzp commented Jun 27, 2024

Sorry for delayed response, I started working on this issue.
I found some changes were made for source.go and sync.go.

@arsenalzp
Copy link
Contributor

Hello,
How do you think, should be maintain CertPool structure between all functions: in source.go, pem.go, cert_pool.go? Or just between pem.go and cert_pool.go and keep as it is in source.go?

@erikgb
Copy link
Contributor Author

erikgb commented Jun 30, 2024

Hello,

How do you think, should be maintain CertPool structure between all functions: in source.go, pem.go, cert_pool.go? Or just between pem.go and cert_pool.go and keep as it is in source.go?

I am a bit out of context, but if it makes sense to keep the cert pool from source to target, I will imagine that would make the code more compact and easier to read/understand?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants