Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Reorganize directory structure #19

Closed
chivay opened this issue Apr 9, 2020 · 5 comments
Closed

[RFC] Reorganize directory structure #19

chivay opened this issue Apr 9, 2020 · 5 comments
Assignees
Labels
level:medium This issue is of average difficulty priority:medium Priority: medium

Comments

@chivay
Copy link
Contributor

chivay commented Apr 9, 2020

Currently, there's a lot of files in the root directory of the project which seems a bit messy.
My idea would be to split code into 3 directories:

  • libursa - after library target in CMake
  • src - containing source files of executables (with one directory per executable (?))
  • third-party - with 3rd party libraries

(EDIT) Or maybe move libursa into src? Either way, i'm looking for suggestions 🤔

@msm-code @icedevml

@msm-code
Copy link
Contributor

msm-code commented Apr 9, 2020

what do you mean by the first part (after library target)? The location when the compiled files will appear?

I'd also like to:

  • get rid of ./contrib - this is straightforward, we don't even package ursadb as .deb right now (that was the original goal)
  • get rid of ./test - having static files for testing in the repository is not wrong by itself, but this means that ./ursadb_test will only run correctly from the repository root (and it writes to files in cwd to make things worse).

But overall, a nice idea 👍

@msm-code msm-code added level:medium This issue is of average difficulty priority:medium Priority: medium status:up for grabs This issue is a good candidate for PR labels Apr 9, 2020
@chivay
Copy link
Contributor Author

chivay commented Apr 9, 2020

what do you mean by the first part

Directory named after ursa library target.
I think it's reasonable to separate core library source files and basically everything else.

@msm-code
Copy link
Contributor

msm-code commented Apr 9, 2020

👍 yes

@chivay
Copy link
Contributor Author

chivay commented Apr 10, 2020

Reorganization preview: 41ab2ad

@chivay chivay self-assigned this Apr 10, 2020
@chivay chivay removed the status:up for grabs This issue is a good candidate for PR label Apr 10, 2020
@chivay
Copy link
Contributor Author

chivay commented Apr 10, 2020

resolved in #22

@chivay chivay closed this as completed Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level:medium This issue is of average difficulty priority:medium Priority: medium
Projects
None yet
Development

No branches or pull requests

2 participants