Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certbot-nginx requires acme >= 0.25 #6096

Closed
hlieberman opened this issue Jun 12, 2018 · 1 comment
Closed

certbot-nginx requires acme >= 0.25 #6096

hlieberman opened this issue Jun 12, 2018 · 1 comment

Comments

@hlieberman
Copy link
Member

Because of the import of symbols from acme.magic_typing, the nginx plugin released in 0.25 depends on acme 0.25 or better. However, setup.py only lists acme>0.21.1, leading to a failure to build from source (and potential run-time failures).

@elyscape
Copy link
Contributor

elyscape commented Jun 12, 2018

Actually, it looks like certbot-nginx isn't the only thing that needs to require acme>=0.25.0 but doesn't. It looks like certbot, certbot-apache, and certbot-dns-route53 all also use acme.magic_typing but only list acme>0.24.0 in setup.py.

Edit: Never mind. Since the only version that satisfies acme>0.24.0 is 0.25.0, it doesn't really matter in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants