Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker images/tags should be signed. #8878

Closed
homotechsual opened this issue Jun 1, 2021 · 3 comments
Closed

Docker images/tags should be signed. #8878

homotechsual opened this issue Jun 1, 2021 · 3 comments
Labels
area: docker area: pkging area: security needs-update priority: unplanned Work that we believe should be done, but does not have a higher priority.

Comments

@homotechsual
Copy link

If you're having trouble using Certbot and aren't sure you've found a bug or
request for a new feature, please first try asking for help at
https://community.letsencrypt.org/. There is a much larger community there of
people familiar with the project who will be able to more quickly answer your
questions.

My operating system is (include version):

Ubuntu 20.04 (Server)

I installed Certbot with (snap, OS package manager, pip, certbot-auto, etc):

Docker

I ran this command and it produced this output:

docker trust inspect --pretty certbot/certbot

No signatures or cannot access certbot/certbot

Certbot's behavior differed from what I expected because:

Given the security-focussed nature of what certbot does and the space in which it operates the docker images should be signed to help defend against supply-chain attacks or copy-cat images trying to MITM the official Certbot images.

https://docs.docker.com/engine/security/trust/

@alexzorin alexzorin added area: docker area: pkging area: security priority: significant Issues with higher than average priority that do not need to be in the current milestone. labels Jun 3, 2021
@alexzorin
Copy link
Collaborator

Hi,

Thanks for the suggestion.

I think we'd want to verify that this would measurably improve the security for users.

e.g. If Docker Hub does centralized key distribution, what stops them from MITMing our keys and images? If users still have to trust Docker Hub, what does signing achieve that downloading the images over HTTPS doesn't?

If you (or anyone) has a more in-depth understanding of Docker Content Trust, any input would be great.

@alexzorin alexzorin added priority: unplanned Work that we believe should be done, but does not have a higher priority. and removed priority: significant Issues with higher than average priority that do not need to be in the current milestone. labels Jun 9, 2021
@github-actions
Copy link

We've made a lot of changes to Certbot since this issue was opened. If you still have this issue with an up-to-date version of Certbot, can you please add a comment letting us know? This helps us to better see what issues are still affecting our users. If there is no activity in the next 30 days, this issue will be automatically closed.

@github-actions
Copy link

This issue has been closed due to lack of activity, but if you think it should be reopened, please open a new issue with a link to this one and we'll take a look.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docker area: pkging area: security needs-update priority: unplanned Work that we believe should be done, but does not have a higher priority.
Projects
None yet
Development

No branches or pull requests

2 participants