RFC8738: support for IP address SANs

[KazamaSion]

My operating system is (include version):

Alpine Linux v3.12 (Environment: Official certbot docker)

I installed Certbot with (snap, OS package manager, pip, certbot-auto, etc):

docker

I ran this command and it produced this output:

certbot certonly --agree-tos --manual \
  --preferred-challenges http \
  --server https://example.com/directory \
  --eab-kid abcdefg \
  --eab-hmac-key abcdefghijklmn\
  -d 1.1.1.1 -v

Requested name 1.1.1.1 is an IP address. The Let's Encrypt certificate authority will not issue certificates for a bare IP address.

Certbot's behavior differed from what I expected because:

Should not detect if requesting IP certs while using custom ACME server.

[alexzorin]

Support was recently added to the acme library, but Certbot itself still does not support IP SANs.

The error message could perhaps more accurately say "Certbot does not support ...".

[github-actions]

We've made a lot of changes to Certbot since this issue was opened. If you still have this issue with an up-to-date version of Certbot, can you please add a comment letting us know? This helps us to better see what issues are still affecting our users. If there is no activity in the next 30 days, this issue will be automatically closed.

[alexzorin]

I'm going to rename this issue, as resolving it requires implementing RFC8738 fully, and not just removing the check for the IP address. We still do not have any plans to work on this.

[github-actions]

We've made a lot of changes to Certbot since this issue was opened. If you still have this issue with an up-to-date version of Certbot, can you please add a comment letting us know? This helps us to better see what issues are still affecting our users. If there is no activity in the next 30 days, this issue will be automatically closed.

[github-actions]

This issue has been closed due to lack of activity, but if you think it should be reopened, please open a new issue with a link to this one and we'll take a look.