Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS-OVH: documentation: please narrow down the list of required API paths #9747

Open
jaskij opened this issue Aug 15, 2023 · 0 comments
Open

Comments

@jaskij
Copy link

jaskij commented Aug 15, 2023

Currently, the documentation for the DNS OVH plugin lists a pretty wide set of required permissions for API keys:

  • GET /domain/zone/
  • GET /domain/zone/<REQUIRED_DOMAIN>/*
  • PUT /domain/zone/<REQUIRED_DOMAIN>/*
  • POST /domain/zone/<REQUIRED_DOMAIN>/*
  • DELETE /domain/zone/<REQUIRED_DOMAIN>/*

Which is quite broad, and includes endpoints such as /domain/zone/<REQUIRED_DOMAIN>/terminate or DNSSEC management.

Despite it being a little more work for the user, I believe it would be better to have a more detailed and narrow list, to limit the amount of permissions the API key has, as a matter of principle.

Using Certbot 2.1, I was able to trial-and-error narrow the list down to:

  • GET /domain/zone/
  • GET /domain/zone/<REQUIRED_DOMAIN>/
  • GET /domain/zone/<REQUIRED_DOMAIN>/status
  • POST /domain/zone/<REQUIRED_DOMAIN>/refresh
  • GET /domain/zone/<REQUIRED_DOMAIN>/record
  • POST /domain/zone/<REQUIRED_DOMAIN>/record
  • GET /domain/zone/<REQUIRED_DOMAIN>/record/*
  • PUT /domain/zone/<REQUIRED_DOMAIN>/record/*
  • POST /domain/zone/<REQUIRED_DOMAIN>/record/*
  • DELETE /domain/zone/<REQUIRED_DOMAIN>/record/*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant