Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gov: fix parameter change proposals #145

Merged
merged 4 commits into from
Nov 5, 2020
Merged

Conversation

dshe-certik
Copy link
Contributor

@dshe-certik dshe-certik commented Nov 5, 2020

Related: #146

Description

This work was initialized by @ziyi-zhang-1130 and was targeting to have claim proposals fully tested by increasing number of passed proposals in simulations.

However, we found this update exposed some problems with parameter change proposals, so we made it an independent PR and will try to fix parameter change proposals in this PR.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]"

@ziyi-zhang-1130
Copy link
Contributor

Will look into this 🧐

@dshe-certik dshe-certik changed the title gov: increase voters and yes votes in simulations gov: fix parameter change proposals Nov 5, 2020
@ziyi-zhang-1130 ziyi-zhang-1130 marked this pull request as ready for review November 5, 2020 20:34
@codecov-io
Copy link

Codecov Report

Merging #145 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   53.76%   53.76%           
=======================================
  Files          49       49           
  Lines        3383     3383           
=======================================
  Hits         1819     1819           
  Misses       1432     1432           
  Partials      132      132           

@dshe-certik dshe-certik merged commit f3ed0e0 into master Nov 5, 2020
@dshe-certik dshe-certik deleted the gov/sims-more-passed branch November 5, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants