Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken link when clicking on monitor -> queue #170

Closed
aaronkaplan opened this issue Sep 3, 2018 · 3 comments
Closed

broken link when clicking on monitor -> queue #170

aaronkaplan opened this issue Sep 3, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@aaronkaplan
Copy link
Member

When clicking on a queue name in the "monitor" tab, you will end up with a broken link.

example:

http://mydomain.com/?page=monitor -> is the monitor page.

Clock on a link, example cymry-whois-expert, you will be redirected to
http://mydomain.com/monitor.html?bot_id=cymru-whois-expert

You actually want to have an URL such as:
http://mydomain.com/?page=monitor&bot_id=cymru-whois-expert

I think this can be fixed very easily. It's probably just an adaptation in the template.

@aaronkaplan aaronkaplan added the bug label Sep 3, 2018
@aaronkaplan aaronkaplan added this to the 1.0.2 milestone Sep 3, 2018
@aaronkaplan aaronkaplan assigned e3rd and ghost Sep 3, 2018
@ghost
Copy link

ghost commented Sep 3, 2018

Looks like a duplicate of #157

Should be fixed in the maintenance and develop branch. Can you confirm this?

@e3rd
Copy link
Member

e3rd commented Sep 17, 2018

Hi, I've been out for three weeks.

I've looked into the code and whole buggy part is fixed in the maintenance branch and completely rewritten in the develop branch. When any of these branches gets merged into the master, lets close the issue.

@aaronkaplan
Copy link
Member Author

aaronkaplan commented Sep 17, 2018 via email

@ghost ghost closed this as completed Nov 9, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants