node: don't allow obs reqs if the queue is full #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ifb0d038fa3adeddc6226e2289fe9dbfc8e39b4e7
✅ Deploy Preview for tubular-dango-1656b2 canceled.
|
bruce-riley
changed the title
leoluk
approved these changes
Aug 13, 2022
SEJeff
approved these changes
Aug 14, 2022
There was a problem hiding this comment.
Love it! Do we want to consider bumping this channel size up a bit? Say maybe 100? During the worst events I've ever seen, we once had about 80 or so when the L1 was going bananas and nodes were dropping left and right.
Trying to rapid fire reobservations via some unspeakable shell one liners is how I found the "feature". This looks great!
|
We discussed increasing the queue size and decided to leave it as is for now. |
bruce-riley
added a commit
that referenced
this pull request
Aug 15, 2022
Change-Id: Ifb0d038fa3adeddc6226e2289fe9dbfc8e39b4e7
jynnantonix
reviewed
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ifb0d038fa3adeddc6226e2289fe9dbfc8e39b4e7
Jeff noticed a while ago that too many reobservation requests can hang the guardian. This is because an attempt to write to the channel hangs if the channel has reached capacity. This PR addresses by making sure the channel is not full before writing to it.
This change is