coap minimal

[alashkin]

Hi, @mmikulicic !

Please, review this PR.
Since this is my first protocol added to fossa, I'm not sure that I'm right in details.

Please, take a look. (aka PTAL)

[mkmik]

FYI: PTAL means Please Take Another Look

[alashkin]

FYI: PTAL means Please Take Another Look

BTW, Urban dictionary offers another :-)

[mkmik]

We have a documentation extraction from comments.

It works if a comment is right before a function declaration.

I noticed that:

/* Options memory management functions */
void ns_coap_free_options(struct ns_coap_message *cm) {

Is meant to be a grouping comment but ended up being interpreted as a function comment.

Why not just add a short comment for all exported functions ?

[alashkin]

Why not just add a short comment for all exported functions ?

Why not? I'll add. :)

[mkmik]

LGTM, but why don't you develop in our main repo so that we get circleci tests ?

[alashkin]

but why don't you develop in our main repo so that we get circleci tests ?

I started this PR in my fork, so I decided to finish it there.
But, next PR about coap will be from main repo's branch.

[mkmik]

Ok, you can run the same tests as the CI locally with:

make -C test docker

The unit test fails in C++ mode:

docker run --rm -v /Users/mkm/Projects/cesanta/fossa/test/../..:/cesanta cesanta/fossa_test
make: Entering directory `/cesanta/fossa/test'
CLEAN   coverage
CLEAN   all
make[1]: Entering directory `/cesanta/fossa/test'
CC      unit_test_cxx
CC      unit_test_ansi
CC      unit_test_c99
CC      unit_test_c11
unit_test.c: In function 'const char* test_coap()':
unit_test.c:2107:22: error: narrowing conversion of '233' from 'int' to 'char' inside { } is ill-formed in C++11 [-Werror=narrowing]
     0xd1, 0x23, 0x11 };
                      ^
unit_test.c:2107:22: error: narrowing conversion of '144' from 'int' to 'char' inside { } is ill-formed in C++11 [-Werror=narrowing]
unit_test.c:2107:22: error: narrowing conversion of '184' from 'int' to 'char' inside { } is ill-formed in C++11 [-Werror=narrowing]
unit_test.c:2107:22: error: narrowing conversion of '209' from 'int' to 'char' inside { } is ill-formed in C++11 [-Werror=narrowing]
unit_test.c:2109:28: error: narrowing conversion of '233' from 'int' to 'char' inside { } is ill-formed in C++11 [-Werror=narrowing]
     0x60, 0x00, 0xe9, 0x1b };
                            ^
unit_test.c:2127:10: error: narrowing conversion of '144' from 'int' to 'char' inside { } is ill-formed in C++11 [-Werror=narrowing]
     0x2e };
          ^
unit_test.c:2127:10: error: narrowing conversion of '255' from 'int' to 'char' inside { } is ill-formed in C++11 [-Werror=narrowing]
unit_test.c:2134:40: error: narrowing conversion of '149' from 'int' to 'char' inside { } is ill-formed in C++11 [-Werror=narrowing]
     0x6d, 0x79, 0x64, 0x61, 0x74, 0x61 };
                                        ^
unit_test.c:2134:40: error: narrowing conversion of '183' from 'int' to 'char' inside { } is ill-formed in C++11 [-Werror=narrowing]
unit_test.c:2134:40: error: narrowing conversion of '255' from 'int' to 'char' inside { } is ill-formed in C++11 [-Werror=narrowing]
unit_test.c:2136:28: error: narrowing conversion of '255' from 'int' to 'char' inside { } is ill-formed in C++11 [-Werror=narrowing]
     0xFF, 0x00, 0xFF, 0x00 };
                            ^
unit_test.c:2136:28: error: narrowing conversion of '255' from 'int' to 'char' inside { } is ill-formed in C++11 [-Werror=narrowing]
unit_test.c:2141:40: error: narrowing conversion of '149' from 'int' to 'char' inside { } is ill-formed in C++11 [-Werror=narrowing]
     0x6d, 0x79, 0x64, 0x61, 0x74, 0x61 };
                                        ^
unit_test.c:2141:40: error: narrowing conversion of '183' from 'int' to 'char' inside { } is ill-formed in C++11 [-Werror=narrowing]
unit_test.c:2141:40: error: narrowing conversion of '241' from 'int' to 'char' inside { } is ill-formed in C++11 [-Werror=narrowing]
cc1plus: all warnings being treated as errors
make[1]: *** [unit_test-cxx] Error 1
make[1]: Leaving directory `/cesanta/fossa/test'
make: *** [compile] Error 2
make: Leaving directory `/cesanta/fossa/test'
make: *** [docker] Error 2

[mkmik]

Another minor thing. Please follow our styleguide for git commit messages (refer to github styleguide)

make setup-hooks will check a few things about commit message styles.

[alashkin]

Marko,

1. Comments fixed.
2. Unit-tests fixed.
3. Commit message updated.

And finally - I promise, tomorrow I'll move to main repo. No more independent PR!

PTAL

[mkmik]

Looks good! Merging