Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if transforms are affine #262

Closed
javagl opened this issue Jan 11, 2023 · 0 comments · Fixed by #263
Closed

Check if transforms are affine #262

javagl opened this issue Jan 11, 2023 · 0 comments · Fixed by #263

Comments

@javagl
Copy link
Contributor

javagl commented Jan 11, 2023

Brought up via CesiumGS/3d-tiles#711:

The specification says that each transform must be an affine matrix.

The validator currently only checks whether a matrix is the zero-matrix. But it should check whether it is affine (i.e. whether the last row is (0,0,0,1), up to an epsilon).

(Whether or not non-invertible matrices should be allowed is open for debate, but checking them for being affine at least matches the current specification)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant