Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter not working for older versions of Node #110

Closed
lilleyse opened this issue Jun 24, 2016 · 3 comments
Closed

Converter not working for older versions of Node #110

lilleyse opened this issue Jun 24, 2016 · 3 comments
Labels

Comments

@lilleyse
Copy link
Contributor

Brought up in CesiumGS/obj2gltf#11

In Node v0.10.42 the Array.prototype.fill function, likely among other things, is not supported. If it's not too much trouble we should support these older versions since they are the latest in some package managers.

@lilleyse lilleyse added the bug label Jun 24, 2016
@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 25, 2016

I would rather support Node v4.4.x LTS.

@mramato what is the recommended practice?

@mramato
Copy link
Contributor

mramato commented Jun 28, 2016

I would recommend supporting 4.x and newer. It looks like we currently run travis in this repository against 4.0.0, which means we're already doing that. While 4.4.x is the current release, the minor version changes fairly often and the entire 4.x baseline is what is official supported by Node.

v0.10.x and v0.12.x are already in maintenance mode and will officially be end-of-life at the end of the year

Node LTS working group

@lilleyse
Copy link
Contributor Author

Okay that sounds fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants