Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combineNodes conversion issue #177

Closed
lilleyse opened this issue Oct 24, 2016 · 2 comments
Closed

combineNodes conversion issue #177

lilleyse opened this issue Oct 24, 2016 · 2 comments

Comments

@lilleyse
Copy link
Contributor

When running a billboard model through the pipeline I noticed that when combineNodes runs the processed model is incorrect. Is it because the root node has a non-identity matrix?

billboard_correct

billboard_incorrect

treeBillboard.txt

@lasalvavida
Copy link
Contributor

So, this is a tricky one. combineNodes flattens out the node transforms onto the points correctly. However, even though this model declares a Y-Up transform in the glTF, the vertex shader discards the rotation and scale of the model matrix and applies the Y-Up transform itself. After conversion, the points are already Y-Up, and then the shader applies the transform again.

If you delete the Y-Up transform node and make Plane the root node, this model displays correctly before and after conversion.

I don't think there is a reasonable way to handle people doing custom modifications in the vertex shader like this.

@lilleyse
Copy link
Contributor Author

Ok, thanks for looking into this - and yes it's a weird case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants