The rpc-reply element tag is not always in the correct namespace

[p-jean]

Summary:
If the client uses a prefix for the NETCONF namespace then the rpc-reply element tag is not in the NETCONF namespace

Details:
The Python library ncclient sends an rpc beginning as follows. Note that there is an 'nc' prefix on the rpc tag:
<nc:rpc xmlns:nc="urn:ietf:params:xml:ns:netconf:base:1.0" message-id="urn:uuid:b9e28b4b-6bf2-4606-9e5a-9bc08074d609"><nc:edit-config>

The reply from libnetconf2 is as follows:
<rpc-reply xmlns:nc="urn:ietf:params:xml:ns:netconf:base:1.0" message-id="urn:uuid:b9e28b4b-6bf2-4606-9e5a-9bc08074d609"><ok/></rpc-reply>

Note that there is no 'nc' prefix on the rpc-reply tag. The response is not recognized and ncclient times out. I believe that it is because the rpc-reply element tag is not in the NETCONF namespace.

I think that the correct response would need to have a prefix on the rpc-reply tag:
<nc:rpc-reply xmlns:nc="urn:ietf:params:xml:ns:netconf:base:1.0"

NETCONF seems to require that the rpc attributes are echoed back verbatim.

I made an attempt to fix it, however I don't suppose my change is very clean. I have done limited testing so far, but I was able to get further with ncclient.

Thanks
fix_reply_namespace .patch.txt

[michalvasko]

Hi,
it should be fixed, thanks for the patch.

Regards,
Michal

[p-jean]

Hi Michal,

Thanks for the great libraries.

BTW - is there any sort of forum or place online to discuss libyang,
libnetconf2, or Netopeer2?

..PJ

On Tue, Nov 15, 2016, at 02:06 AM, michalvasko wrote:

Hi,
it should be fixed, thanks for the patch.
Regards,
Michal
— You are receiving this because you authored the thread. Reply to
this email directly, view it on GitHub[1], or mute the thread[2].

Links:

1. The rpc-reply element tag is not always in the correct namespace #15 (comment)
2. https://github.com/notifications/unsubscribe-auth/ALM2wVgjZuq8kXJMtD8CbM1Zn6_Bua_yks5q-YQYgaJpZM4KszKd

[rkrejci]

Hi PJ,
we use mainly the github issue trackers for the projects, but there are also mailing lists of sysrepo which is closely connected with the Netopeer2, so you can discuss the general things there.

Regards,
Radek