Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of Virtual Destructor Incorrect #34

Closed
rmerriam opened this issue Jun 21, 2017 · 5 comments
Closed

Refactor of Virtual Destructor Incorrect #34

rmerriam opened this issue Jun 21, 2017 · 5 comments
Assignees
Labels
Projects

Comments

@rmerriam
Copy link

Starting with the destructor:

virtual ~TaskStatus() override = default;
the suggestion is to add "noexcept". Accepting this change results in:

virtual ~TaskStatus() override noexcept override = default;

Cevelop 1.7.1
GCC 4.9
Ubuntu 14.04.5

@tcorbat
Copy link

tcorbat commented Jun 22, 2017

Thanks for this report as well! I reproduced the issue. I'll have to figure out whether the problem is within our code or whether it has to be fixed in Eclipse CDT (which might take longer until the next release, as it is too late for Oxygen).

@tcorbat
Copy link

tcorbat commented Jun 22, 2017

As I thought this issue occurs due to a bug in CD [1]. I'll fix it there and we will have it with one of the next releases (probably with CDT 9.3.1).

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=518628

@tcorbat tcorbat self-assigned this Jun 22, 2017
@tcorbat tcorbat added the bug label Jun 22, 2017
@rmerriam
Copy link
Author

Since you're tied into the CDT work I'll mention this problem. Inside a class define:

virtual func() override {}

Do a ctrl-t to make it an inline in the header and the override is carried along.

@tcorbat
Copy link

tcorbat commented Jun 23, 2017

Right, thanks for mentioning it. This has already been reported [1]. I'll have a look at it.

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=518273

@fmorgner fmorgner added this to To do in Core Mar 1, 2018
@Darnor
Copy link

Darnor commented Aug 6, 2019

Both upstream bugs have been fixed quite a while ago, so I'll assume this issue resolved.

@Darnor Darnor closed this as completed Aug 6, 2019
Core automation moved this from To do to Done Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Core
  
Done
Development

No branches or pull requests

3 participants