Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a signed integer type for DiscreteElementType #77

Open
tpadioleau opened this issue Aug 4, 2022 · 1 comment
Open

Use a signed integer type for DiscreteElementType #77

tpadioleau opened this issue Aug 4, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@tpadioleau
Copy link
Member

With the recent possibility for mdspan to choose the index_type, I think we should a signed integer type common for DiscreteElementType, std::extents and iterators difference_type that is to say std::ptrdiff_t.
@tpadioleau tpadioleau mentioned this issue Nov 8, 2023
Closed
@tpadioleau tpadioleau added the enhancement New feature or request label Nov 22, 2023
@tpadioleau tpadioleau mentioned this issue Nov 22, 2023
Merged
@tpadioleau
Copy link
Member Author

tpadioleau commented Nov 28, 2023 •
edited
Loading

Re-enable -Wsign-compare in the CI because of #237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tpadioleau