Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Enhancements to "Convert to string interpolation" #83

Open
bjansen opened this issue Sep 26, 2016 · 1 comment
Open

Enhancements to "Convert to string interpolation" #83

bjansen opened this issue Sep 26, 2016 · 1 comment
Milestone

Comments

@bjansen
Copy link
Contributor

bjansen commented Sep 26, 2016

It seems to me that the current behavior of "Convert to string interpolation" could be improved a little. Given this example code:

value foo = "\"" + name + "\" \"" + version + "\"";

I get inconsistent behavior depending on which + the quick assist is called on:

  • on the first +, it results in "\"``name``" + "\" \"" + version + "\""
  • ...
  • on the last + it results in "\"``name``\" \"``version``\""

In my opinion, it should always result in "\"``name``\" \"``version``\"".

@bjansen bjansen added this to the 1.3.1 milestone Sep 26, 2016
@bjansen
Copy link
Contributor Author

bjansen commented Sep 26, 2016

Also, for some reason, "a" + "b" is transformed to "a``"b"``", instead of simply "ab". I think it should be easy to detect string literals and avoid surrounding them with backticks.

@bjansen bjansen modified the milestones: 1.3.1, 1.3.2 Nov 21, 2016
@bjansen bjansen modified the milestones: 1.3.2, 1.3.3 Mar 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant