Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why not make system independent so that each bundle size get reduce.. #38

Closed
ngoyal16 opened this issue Jan 25, 2019 · 2 comments
Closed
Projects

Comments

@ngoyal16
Copy link
Member

why not make the system independent so that each bundle size get reduce and easy to maintain...

  1. admin interface
  2. api code
  3. store code

if you think that code is very integrated with each other then uses git submodule feature for common code.. this way.. each of the code gets separated.. and new members of this project can understand its function.

you can start this by moving out admin panel from the code... i can help you with that because last night I struggle with many problems to make them independent.

@ngoyal16
Copy link
Member Author

it also helps peoples to make admin & store panel on separate domains which can help to protect their admin by firewalls too easily.

@LuBuss
Copy link
Member

LuBuss commented Jan 25, 2019

We have had this conversation before, I added a poll in the slack channel to try resolve if you will accept the changes or not. https://join.slack.com/t/cezerin2/shared_invite/enQtNTE5NzYxMzA5ODc5LTVkZjM4ODUwMmNlMmMyZTkxYjg5N2QxZmQ5NjA1NTg3OWM2ZjU1NzVmNWM0N2E3ZmJjM2Q3MjQ5OGFmNTBmYjg

@ngoyal16 ngoyal16 added this to To do in v1.0 Feb 18, 2019
@vamcart vamcart closed this as completed Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v1.0
  
To do
Development

No branches or pull requests

3 participants