Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listeners remove html attributes #184

Closed
davidbrooksio opened this issue Sep 12, 2023 · 4 comments
Closed

Listeners remove html attributes #184

davidbrooksio opened this issue Sep 12, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@davidbrooksio
Copy link

davidbrooksio commented Sep 12, 2023

Test case: https://codepen.io/davidbrooksio/pen/PoXeEwg

It's all there in my test case but the crux of it is that as soon as I add the listener code (for example let events = listeners({ log });) certain attributes are arbitrarily removed from the rendered html. My test case shows that the class has been removed from the spans and also some of the data- attributes are removed but weirdly some data- attributes remain.

I'm happy to submit any more information if required, just let me know.

@davidbrooksio
Copy link
Author

Hi again. I realise that is project is maintained by one guy (@cferdinandi) so I understand that fixes can sometimes take a long time and that's fine, it's "free" software after all. I was just wondering if this project is still being developed?
It's fine if it isn't I just need to know if I should look elsewhere or hold out for a fix.
Thank you.

@cferdinandi
Copy link
Owner

@davidbrooksio it is, but I've had 0 time to look into this issue. Thanks for the reduced test case. I can clearly see the issue in action. I'll try to debug this soon.

@cferdinandi cferdinandi added the bug Something isn't working label Sep 26, 2023
@davidbrooksio
Copy link
Author

Hi @cferdinandi, thank you for your reply. I know what it's like maintaining projects and juggling everything else so I hope you don't think I was being pushy. Please let me know if you need me to test anything.

@cferdinandi
Copy link
Owner

@davidbrooksio Alright, just pushed version 12.3.2, which fixes this issue. Thanks for letting me know about it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants