Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the established Consul connection in ConsulConfigurationSource #143

Closed
fromanator opened this issue Apr 7, 2016 · 2 comments
Closed
Assignees
Labels
Milestone

Comments

@fromanator
Copy link

Just wondering if you had any concerns or thoughts about exposing https://github.com/cfg4j/cfg4j/blob/master/cfg4j-consul/src/main/java/org/cfg4j/source/consul/ConsulConfigurationSource.java#L100 to be retrieved and used.

I figured it might be useful for use cases where you want a Consul client connection for something else, and you might as well use the one already established by cfg4j instead of making a new one.

@norbertpotocki
Copy link
Member

That's a very reasonable idea but for now I was thinking of keeping the consul connector hidden from the users. Consul-client is a fairly new library and its interface may change. We may also decide to use some other library for communicating with consul down the road. If we mix their interface with ours that won't be as easy anymore. It just doesn't feel worth it (combining that with the fact that gains from sharing the client probably aren't that big). Does that make sense?

@norbertpotocki norbertpotocki self-assigned this Apr 8, 2016
@norbertpotocki norbertpotocki added this to the Backlog milestone Apr 8, 2016
@fromanator
Copy link
Author

Yeah it totally makes sense, wanted to get your opinion on it before working on anything since I had similar reservations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants